From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id D1C192E81 for ; Sat, 27 Oct 2018 01:25:11 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 727CA21F01; Fri, 26 Oct 2018 19:25:11 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 26 Oct 2018 19:25:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=g8GuYjPczfuVBW4sDgWy46J+mJ2e1GlgvlI0q+UZb8g=; b=rffUIFKS0Yvy SYKvUHx8t5EiTw+CS+dKgLrhQMMcqKYVl5N5jh606i83i3eJSDtsUUofaH69Gkls vH0JfH0LOeg7dACRepcJri2YElFmI4L9uM2V6X6jw9p/1yFh0QgOHPQr1btdE0/b oestdUJ2Sz3dY14PYBlG5ZcgAYRbhCM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=g8GuYjPczfuVBW4sDgWy46J+mJ2e1GlgvlI0q+UZb 8g=; b=KAlXaUG6NEXnc+QRXW/uh4guTxkg050/EHC0ojEx0SFZrKrMCApkjKMgs T2Y72cTcYTg9DWHALSv2Y4Uk8w+Xhqty4SeLGE40ZKxRRRb77NXqWv0hDXltgutk lRSg6xyxZLGv5GCFGnf/0voU/D+JA2p6TJZf4+6cdYJlxdtI+JhOLqmClfdzw/6A P7Vjo9ULam77gZX6fWBr6WScvMK3WCbbjnLOGDn9x/y6ImyZWcH4xdL2hgPa12X7 4YK8kcjMoJjZ7u+h/RCfhaRzq9dY6vq/WmGuuR7Oc1ano6X9uqxAudlhQVB3xjxO Zu3UtskAciWhUbHMiPHFDJx3Ijy7Q== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 66DDEE4897; Fri, 26 Oct 2018 19:25:10 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: Ferruh Yigit , phil.yang@arm.com, gavin.hu@arm.com, honnappa.nagarahalli@arm.com Date: Sat, 27 Oct 2018 01:25:16 +0200 Message-ID: <19506887.xJU308vF1C@xps> In-Reply-To: <809e8e42-0deb-e53d-f5e4-acd4bc2f5d0b@intel.com> References: <20181026214027.29465-1-thomas@monjalon.net> <4880956.RWMF3eIYHy@xps> <809e8e42-0deb-e53d-f5e4-acd4bc2f5d0b@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] kni: fix build on Linux < 3.14 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Oct 2018 23:25:12 -0000 27/10/2018 00:42, Ferruh Yigit: > On 10/26/2018 10:56 PM, Thomas Monjalon wrote: > > 26/10/2018 23:40, Thomas Monjalon: > >> The atomic functions smp_load_acquire() and smp_store_release() > >> were introduced in Linux 3.14. Older kernels miss the functions: > >> > >> kni_fifo.h:19:2: error: > >> implicit declaration of function =E2=80=98smp_load_acquire=E2=80=99 > >> kni_fifo.h:30:2: error: > >> implicit declaration of function =E2=80=98smp_store_release=E2=80=99 > >> > >> The fallback is to drop the atomic barrier, as it was before > >> the commit below. > >> > >> Fixes: 711859cd0d07 ("kni: fix kernel FIFO synchronization") > >> > >> Signed-off-by: Thomas Monjalon >=20 > Tested-by: Ferruh Yigit Applied