From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f175.google.com (mail-wi0-f175.google.com [209.85.212.175]) by dpdk.org (Postfix) with ESMTP id 72130374D for ; Wed, 1 Jul 2015 23:37:28 +0200 (CEST) Received: by wiga1 with SMTP id a1so136802214wig.0 for ; Wed, 01 Jul 2015 14:37:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=ZY9lzL6ycgVmFEN5sXvPcF0i5GGk3J4SO7PSnfN/PFQ=; b=fLOlngD59oqvDwKtvxkQgiO34SIb/js4E2bFSmvBpKukkpgKCqr2Lb9gbJl5rFK9HS 4iOQUvPAAFo9ePWOKnIRDVYx2vDtc/UcEor71byvEfAPhWUfV5pl8jyPKHfOXmtJ4lNV qHDJoEPXVf7kUJBfXgJxj20IElqj+ef7bqPdsFfgsVoC4/1XN1D5x2K+HfrZWx07q9c8 BzjlpaNvOV5/G32EJ8libntldQRpSiOG8spaYHgznEP1j6KCiz/EwHTkDY00VeRCYb/V Tm9678eloogbrtfc/NPhsTR42Q+TwNGJCkY4Vo8ArRSJZFN/TubuVbE0Xl1KPAb9cizF oF2Q== X-Gm-Message-State: ALoCoQnkzYVtnbiI5Gl1r+OwnUfrzez5Nq6eIV4BLH4LRT7PXrlzdiXKvFCmkWph4Afeg61zqM2q X-Received: by 10.194.2.161 with SMTP id 1mr50964812wjv.143.1435786648341; Wed, 01 Jul 2015 14:37:28 -0700 (PDT) Received: from xps13.localnet (guy78-1-82-235-116-147.fbx.proxad.net. [82.235.116.147]) by mx.google.com with ESMTPSA id l7sm5248000wic.2.2015.07.01.14.37.27 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 01 Jul 2015 14:37:27 -0700 (PDT) From: Thomas Monjalon To: "Mrzyglod, DanielX T" Date: Wed, 01 Jul 2015 23:36:19 +0200 Message-ID: <1951620.DRXia7vYdA@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D8912632393071@IRSMSX108.ger.corp.intel.com> References: <1435307833-7432-1-git-send-email-danielx.t.mrzyglod@intel.com> <1435590363-4656-1-git-send-email-danielx.t.mrzyglod@intel.com> <3EB4FA525960D640B5BDFFD6A3D8912632393071@IRSMSX108.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3] cfgfile: fix unitialised buffer X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Jul 2015 21:37:28 -0000 2015-06-29 19:47, Dumitrescu, Cristian: > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Daniel Mrzyglod > > Nature of the problem was not initialised buffer[256], there were probability > > that operation system will provide previously used memory and on special > > condition > > there were probability that string operations will work on random data that > > could provide unexpected program behaviour. > > > > Changes in v3: > > -Simplify the initialization of buffer. > > Changes in v2: > > -Found the real nature of problem. Only buffer was not initilized. > > Changes in v1: > > -Add additional separate IO buffer and initialize both buffers. > > > Acked-by: Cristian Dumitrescu Applied, thanks