From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41])
 by dpdk.org (Postfix) with ESMTP id 594A639EA
 for <dev@dpdk.org>; Thu, 14 Jul 2016 15:37:30 +0200 (CEST)
Received: by mail-wm0-f41.google.com with SMTP id f126so67069053wma.1
 for <dev@dpdk.org>; Thu, 14 Jul 2016 06:37:30 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:user-agent:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=7OWtcSp/PGX+jnKAnFJdR5mJH2DPF70TlOMgAS9t5jw=;
 b=sFXrf8Z9yKWot44GNcwpnG67e00x35W0uHvsvKH8TL9D8hd7xKfvidCWrUKVcVpUuY
 XEFQLwRNfDBdsF6EZtQUgYhRepSNT4TaoNFjl8jS30bJPSMzRagivXktNpgYjbI0GmGU
 WrsSMX0IBHQWtQ0XzbXcuMaIa0YVhbzuKoG5Ww22Eo+yvV6on2l2fQx4rnEqIZQ5qiP5
 9b9Y+p+PWRM5R/dk06KZhwOY1zK8inPQVDgvLdJSSLsGqBTloiTXZmZyDGcg8jXpp5sY
 fWYdzfwFBKtRDkD3toU7gC4w+bLZWU3CKIF0AlVh2l4WJZuXMi6o+i6QtEuPBMarH01K
 oV2g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=7OWtcSp/PGX+jnKAnFJdR5mJH2DPF70TlOMgAS9t5jw=;
 b=QRsU4EHAeenzXYaEsJ9PGzar54PWYX5BFbzLiw0QYVVD6QDHtn61d/6Lkef8U2YPXh
 wc1J05FKL4x/rWQGdxPPyqJzzhXvDOQZbiIL140K5zJkbsPhIFCcSVcMkSc92o2wpG/6
 4Nj4I7jJFhz6HpJ4gHPHRLaL0Pr7tdqlSfDu+TpveDdGUJ62igqs4dQ1LAtY8oxN2ZW6
 UZS5mO58DR9uMNzfMDC5PbxOKTuA3Hp75zBc7KmylIp3K6jeb32hSYpl1o1gQ10BpG3f
 4dmkANbxXscSyEDEdja5pZND67vdW59hD7bDuGjEXFENGo5DnuAGZVlAAmftWXj5vBT2
 7MWQ==
X-Gm-Message-State: ALyK8tKpD7h/YUpCBlKJVsYFZrgvHvXaB1Q4Q6KY9koSy/zc/oAtUYGhpmDHDebDJim9Inat
X-Received: by 10.28.161.196 with SMTP id k187mr7479119wme.20.1468503450086;
 Thu, 14 Jul 2016 06:37:30 -0700 (PDT)
Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184])
 by smtp.gmail.com with ESMTPSA id g67sm3691699wme.5.2016.07.14.06.37.28
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 14 Jul 2016 06:37:29 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Remy Horton <remy.horton@intel.com>
Cc: dev@dpdk.org
Date: Thu, 14 Jul 2016 15:37:28 +0200
Message-ID: <1954062.51W9tGj6hj@xps13>
User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <1195a38d-8615-03d2-22eb-04f6b071d38b@intel.com>
References: <1195a38d-8615-03d2-22eb-04f6b071d38b@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] rte_ether: Driver-specific stats getting overwritten
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Jul 2016 13:37:30 -0000

2016-07-14 14:29, Remy Horton:
> 'noon,
> 
> In rte_eth_stats_get() after doing the driver callout to populate struct 
> rte_eth_stats, the rx_nombuf member is overwritten with 
> dev->data->rx_mbuf_alloc_failed even though some drivers will have 
> filled rx_nombuf with a value from elsewhere. This makes assignment of 
> rx_nombuf from within the driver callout redundant. Is this intentional?

Yes it is strange and has always been like that.
Why not moving the assignment before calling the driver callback?