From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f175.google.com (mail-wr0-f175.google.com [209.85.128.175]) by dpdk.org (Postfix) with ESMTP id E9BAAFAEB for ; Mon, 27 Mar 2017 15:02:58 +0200 (CEST) Received: by mail-wr0-f175.google.com with SMTP id l43so55821788wre.1 for ; Mon, 27 Mar 2017 06:02:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=w6tl1AfEV4fFTYTGUF2tYvprC0deqPdrpY8yOXqojlg=; b=i3MrkCAEXK1cHWSJTHtaw6ZaE3Zssr+PZQkgdtd6UbMB2xLwwgxxsm6JmQW7I+87zJ +uDVojeH5w6RL8zIWCXpeapNI/4mY/Xn4dMynQY72CQK5qH9obR/gvV5bi+N+7XIxJP/ r/czD2llA7W/lmRlEG4EYVzwwM4lC9RPtZo8yZHkout/mL/JmUVrSE36cCNl1sUpN4kQ 2TCuI+qTFE7bwcylvGTeWCsE70GeawfsLluuiykNAJZK9PozpWBXgMHDz3KmsM70b66z EdStQ/fS8MeZbsyoQiAcMp1VmaxnL38TJmvshbLYhJK1I9Sr2Ye4gmAcktgpwjoD0No3 W0ZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=w6tl1AfEV4fFTYTGUF2tYvprC0deqPdrpY8yOXqojlg=; b=tSttSFEMrsQFdsfiN+mQHGKZtjs3G4VhLaYe6no2m4Xp+Nh56JriqHAF/nNkdnufGL oqRfOKtMXuZxXui0AaKc/uPWeWMBHuLVQshhgPgpQ/dzIOeGsIM2YJJqMach9r5c0Qgl aYSqayIPlIn1EvApJKfBqS2mDnfX4pE6p0/g1RFs8ZKVXNyweGi+KbtIxzmeZrX9m+di MCPYjGfb5xY2c7UnO4RbEKmyuvZpdxu0lld4o/3M8aAYpUapn61/AfkstJyBw35R5OId hKVBE2yWFvzKiiPmHK1wHqp8BuIuwiXm5glqLITMweoZrmjMPDl1oAlVz4/+74nRt2fq fqbg== X-Gm-Message-State: AFeK/H3jSCszCYlgCNXJ0kL1cbQnLQoEipiiBUize4PZIMi6S0NeeS/EyqTCxdrATwR0z2r3 X-Received: by 10.28.216.141 with SMTP id p135mr9866100wmg.71.1490619778523; Mon, 27 Mar 2017 06:02:58 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id l41sm647772wre.23.2017.03.27.06.02.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Mar 2017 06:02:57 -0700 (PDT) From: Thomas Monjalon To: David Hunt Cc: dev@dpdk.org, bruce.richardson@intel.com Date: Mon, 27 Mar 2017 15:02:57 +0200 Message-ID: <1955761.tFH3Sr4yC9@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1490004522-183515-9-git-send-email-david.hunt@intel.com> References: <1489558767-56329-2-git-send-email-david.hunt@intel.com> <1490004522-183515-1-git-send-email-david.hunt@intel.com> <1490004522-183515-9-git-send-email-david.hunt@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v11 08/18] lib: add symbol versioning to distributor X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Mar 2017 13:02:59 -0000 2017-03-20 10:08, David Hunt: > Also bumped up the ABI version number in the Makefile It would be good to explain the intent of versioning here. > Signed-off-by: David Hunt > Acked-by: Bruce Richardson > --- > lib/librte_distributor/Makefile | 2 +- > lib/librte_distributor/rte_distributor.c | 57 +++++++++++--- > lib/librte_distributor/rte_distributor_v1705.h | 89 ++++++++++++++++++++++ > lib/librte_distributor/rte_distributor_v20.c | 10 +++ > lib/librte_distributor/rte_distributor_version.map | 14 ++++ > 5 files changed, 162 insertions(+), 10 deletions(-) > create mode 100644 lib/librte_distributor/rte_distributor_v1705.h > > diff --git a/lib/librte_distributor/Makefile b/lib/librte_distributor/Makefile > index 2b28eff..2f05cf3 100644 > --- a/lib/librte_distributor/Makefile > +++ b/lib/librte_distributor/Makefile > @@ -39,7 +39,7 @@ CFLAGS += $(WERROR_FLAGS) -I$(SRCDIR) > > EXPORT_MAP := rte_distributor_version.map > > -LIBABIVER := 1 > +LIBABIVER := 2 Why keeping ABI compat if you bump ABIVER? I guess you do not really want to bump now.