From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f54.google.com (mail-lf0-f54.google.com [209.85.215.54]) by dpdk.org (Postfix) with ESMTP id C90FEADE7 for ; Wed, 22 Jun 2016 08:43:53 +0200 (CEST) Received: by mail-lf0-f54.google.com with SMTP id h129so61868612lfh.1 for ; Tue, 21 Jun 2016 23:43:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=rIlH0L4J87npcQRR/YjaalGJqWodCM1TrZ1ht6OXP/k=; b=efWwmPtS2pb4CPNGQAxk8FfJkyOgUYBkryxOvTdHR+xlPUEDA45eU8IbZ/xwJ7InQn eSOD0CIdtvKrCDc0CbU9y5qGlM/isksVD6+te1tF0McItMNfF/PP44R+9gTnGAvlqfJH mkwjVDRSCaBDBi/6W5IgzojLHW9plzvd9KBhqs3vDxaH+JjhrNpNOwIz8RuGxs4WlsCW DnB5A99GiPZoG1B5ABDzYF0IIsxDvykQ8OyRED+evZwJxWmoMFtU+8Xj5MYxznfuvVWa rYLgKfMOCep9avbSU18wp271uIOGgjicNDDSWiIxbiCXtSYdPWsCLTxG047iKSvVDkaU D48w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=rIlH0L4J87npcQRR/YjaalGJqWodCM1TrZ1ht6OXP/k=; b=McRWCAkgDKtw2ZwNbnV4hvVTmIbtwj7M40j9J/kcmGLSikytWfKtUs29cZC6OUJBYf WMpePMza0DKt0dwtPjResjf87bkWfvk/bEhN16VSvzF2TNWQZFTEr0rFn9/LMZd4yc2T tTW4AG+c70I2P68y3s6qetDbV6loXFPTwZdWxwJQ19/xxTcI4L4m44RB44KLpH3mB/jx MTWa1KerYuZB+5iRAs48RuiJFPYXq9/xbUIC+BHUuxotzLI0+7em71yJbUCUe889jq/+ 4uXtMEIJlvniCuNkBKYf3utZaYSMGzqR8R1EReZ+lsT1ifpvpXu4oXRWWA5K/wf4qkfg Hemw== X-Gm-Message-State: ALyK8tK+m+T89XjiuQ86fiEWiFjfp7FnNT65oDjJPAda8+dkowqiWtTtvHmnHEpk/lWNNByz X-Received: by 10.28.182.68 with SMTP id g65mr6670431wmf.12.1466577833426; Tue, 21 Jun 2016 23:43:53 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id a191sm6460354wme.5.2016.06.21.23.43.52 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 21 Jun 2016 23:43:52 -0700 (PDT) From: Thomas Monjalon To: Jerin Jacob Cc: dev@dpdk.org, bruce.richardson@intel.com, pablo.de.lara.guarch@intel.com, john.mcnamara@intel.com Date: Wed, 22 Jun 2016 08:43:52 +0200 Message-ID: <19576009.SQKuele073@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20160622033048.GA5200@localhost.localdomain> References: <1459250409-5123-2-git-send-email-jerin.jacob@caviumnetworks.com> <2207246.eroZTxtGRd@xps13> <20160622033048.GA5200@localhost.localdomain> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 1/2] ethdev: add tunnel and port RSS offload types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jun 2016 06:43:54 -0000 2016-06-22 09:00, Jerin Jacob: > On Tue, Jun 21, 2016 at 11:02:59PM +0200, Thomas Monjalon wrote: > > Hi Jerin, > > Hi Thomas, > > > > > I wanted to push this patch which is now a dependency of ThunderX > > but I do not fully understand it. > > > > 2016-03-31 02:21, Jerin Jacob: > > > - added VXLAN, GENEVE and NVGRE tunnel flow types > > > - added PORT flow type for accounting physical/virtual > > > port or channel number in flow creation > > [...] > > > --- a/lib/librte_ether/rte_eth_ctrl.h > > > +++ b/lib/librte_ether/rte_eth_ctrl.h > > > @@ -74,7 +74,11 @@ extern "C" { > > > #define RTE_ETH_FLOW_IPV6_EX 15 > > > #define RTE_ETH_FLOW_IPV6_TCP_EX 16 > > > #define RTE_ETH_FLOW_IPV6_UDP_EX 17 > > > -#define RTE_ETH_FLOW_MAX 18 > > > +#define RTE_ETH_FLOW_PORT 18 > > > +#define RTE_ETH_FLOW_VXLAN 19 > > > +#define RTE_ETH_FLOW_GENEVE 20 > > > +#define RTE_ETH_FLOW_NVGRE 21 > > > +#define RTE_ETH_FLOW_MAX 22 > > > > Please could you explain more what is PORT flow? > > For example, a NIC card with two physical port where application > configures RTE_ETH_FLOW_IPV4 for both, In that case > HW generate same RSS value for a similar IPV4 packet, However, in-case if > application want to generate a flow that account physical port also then > it can configure with RTE_ETH_FLOW_IPV4 | RTE_ETH_FLOW_PORT. > > RTE_ETH_FLOW_PORT useful for the case where one physical port assigned for > INBOUND traffic and other-one for OUTBOUND traffic etc OK > > Does it need a comment in the code? > Not sure, commit log has description. How do you expect the user to understand this new value in the API? Users do not check in the git history. They use doxygen, headers comments and/or examples.