* [dpdk-dev] [PATCH] autotests: fix eal flags test
@ 2016-04-04 16:19 Olivier Matz
2016-04-05 9:52 ` De Lara Guarch, Pablo
0 siblings, 1 reply; 3+ messages in thread
From: Olivier Matz @ 2016-04-04 16:19 UTC (permalink / raw)
To: dev; +Cc: chaozhu
Since commit a88ba49e51, values larger than 4 are allowed,
the autotests need to be updated accordingly.
Fixes: a88ba49e51 ("config: fix CPU and memory parameters on IBM POWER8")
Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
---
app/test/test_eal_flags.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c
index d9c0d93..93ae6e7 100644
--- a/app/test/test_eal_flags.c
+++ b/app/test/test_eal_flags.c
@@ -698,8 +698,8 @@ test_invalid_n_flag(void)
const char *argv1[] = { prgname, prefix, no_huge, no_shconf, "-c", "1", "-n"};
/* bad numeric value */
const char *argv2[] = { prgname, prefix, no_huge, no_shconf, "-c", "1", "-n", "e" };
- /* out-of-range value */
- const char *argv3[] = { prgname, prefix, no_huge, no_shconf, "-c", "1", "-n", "9" };
+ /* zero is invalid */
+ const char *argv3[] = { prgname, prefix, no_huge, no_shconf, "-c", "1", "-n", "0" };
/* sanity test - check with good value */
const char *argv4[] = { prgname, prefix, no_huge, no_shconf, "-c", "1", "-n", "2" };
/* sanity test - check with no -n flag */
--
2.1.4
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] autotests: fix eal flags test
2016-04-04 16:19 [dpdk-dev] [PATCH] autotests: fix eal flags test Olivier Matz
@ 2016-04-05 9:52 ` De Lara Guarch, Pablo
2016-04-06 10:02 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: De Lara Guarch, Pablo @ 2016-04-05 9:52 UTC (permalink / raw)
To: Olivier Matz, dev; +Cc: chaozhu
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Olivier Matz
> Sent: Monday, April 04, 2016 5:20 PM
> To: dev@dpdk.org
> Cc: chaozhu@linux.vnet.ibm.com
> Subject: [dpdk-dev] [PATCH] autotests: fix eal flags test
>
> Since commit a88ba49e51, values larger than 4 are allowed,
> the autotests need to be updated accordingly.
>
> Fixes: a88ba49e51 ("config: fix CPU and memory parameters on IBM
> POWER8")
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] autotests: fix eal flags test
2016-04-05 9:52 ` De Lara Guarch, Pablo
@ 2016-04-06 10:02 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2016-04-06 10:02 UTC (permalink / raw)
To: Olivier Matz; +Cc: dev, De Lara Guarch, Pablo, chaozhu
> > Since commit a88ba49e51, values larger than 4 are allowed,
> > the autotests need to be updated accordingly.
> >
> > Fixes: a88ba49e51 ("config: fix CPU and memory parameters on IBM
> > POWER8")
> > Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
>
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-04-06 10:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-04 16:19 [dpdk-dev] [PATCH] autotests: fix eal flags test Olivier Matz
2016-04-05 9:52 ` De Lara Guarch, Pablo
2016-04-06 10:02 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).