From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E27C64332B; Tue, 14 Nov 2023 15:27:37 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BED654027B; Tue, 14 Nov 2023 15:27:37 +0100 (CET) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mails.dpdk.org (Postfix) with ESMTP id 8BCD540279; Tue, 14 Nov 2023 15:27:35 +0100 (CET) Received: from compute7.internal (compute7.nyi.internal [10.202.2.48]) by mailout.west.internal (Postfix) with ESMTP id 72D913202370; Tue, 14 Nov 2023 09:27:31 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Tue, 14 Nov 2023 09:27:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1699972050; x=1700058450; bh=NK8AA6oOU7Nxwb9LfYMI44LEGQqPQhGTzhq 6wOt+jsI=; b=qzZDoaIby8MblGohAm0kGf0mZJBfvisw4oGaf9QCPtRZZg3/qF+ B84IxrjHTX2F/adR+DZ1i470u+jU3DbH7qSN7LAonOsOvkDm3BqMI81TFGvuDRF3 KB4LL78ek8BsTSb5lr8wU579NNU7x40wHmUOExSI16LOG4Ff+79k7vSL7AI75QGH 9TPA3XL1ZO5herb1d6J3DixIOR0AJk0dz4yG3w5nig7WoDqiD8eFDFpy7+KMrhzj sbvqD8faVaUpb626kqzT1MJRz2PNRZahzD1tPuvlu1NRJQdQC+iujKeg30NtGSFI LskC9UW/+zT/D2ZgY/0bcvT7NmEVa3somZQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1699972050; x=1700058450; bh=NK8AA6oOU7Nxwb9LfYMI44LEGQqPQhGTzhq 6wOt+jsI=; b=R36aqCi1fsdTrc4jicjcQeekh/GiHagxgqNy+1KvP7DUHPk4nOM 3EJSv9u+y9+ktBF5tMxvCuugbsdP4S+YoCUbgxEW7imsCeu2Z6vh8WlreNqF9aIk ZT3IDd89YQy0mipfCf0RZeQjaZgWqTytoS7W+ueaK+rmOKGojZ7Wx/U7PYuFnFJk OwjzRAHGJCnPpfoRALWE3fmSMbKqs2Vp446JiQzV2lQs5OGh+/9Fuehyt4LsQ5xt Y+t72lokZO4V1b+8/8SQsS0FXvyiFHfpexzT9arP3Orp8wN9chXSX5l1idx+Jc3G /XM11px9APNJpnAe5dbV92Bv85LyNlbjlIQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudefvddgieefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeegtddtleejjeegffekkeektdejvedtheevtdekiedvueeuvdei uddvleevjeeujeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 14 Nov 2023 09:27:29 -0500 (EST) From: Thomas Monjalon To: Vipin Varghese Cc: cheng1.jiang@intel.com, stable@dpdk.org, anoobj@marvell.com, jerinj@marvell.com, dev@dpdk.org, "lihuisong (C)" Subject: Re: [PATCH v3] app/dma-perf: fix physical address seg-fault Date: Tue, 14 Nov 2023 15:27:26 +0100 Message-ID: <1958005.yKVeVyVuyW@thomas> In-Reply-To: References: <20230816094216.1847-1-vipin.varghese@amd.com> <20231019041956.609-1-vipin.varghese@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 24/10/2023 04:16, lihuisong (C): >=20 > =E5=9C=A8 2023/10/19 12:19, Vipin Varghese =E5=86=99=E9=81=93: > > do_cpu_mem_copy uses DPDK API rte_mbuf_data_iova to return > > the start of the virtual address for both src and dst. > > But in case of iova mode set as PA, this results in seg-fault. > > This is because rte_memcpy uses VA address and not PA. > > > > This fix invokes `rte_pktmbuf_mtod` for both src and dst. > > > > Bugzilla ID: 1269 > > Fixes: 623dc9364dc6 ("app/dma-perf: introduce DMA performance test") > > Cc: cheng1.jiang@intel.com > > > > Cc: stable@dpdk.org > > > > Signed-off-by: Vipin Varghese > > Suggested-by: Anoob Joseph > > Suggested-by: Jerin Jacob > > > Acked-by: Huisong Li Adding some missing acks. Applied, thanks.