* [dpdk-dev] Compilation error by "net/bnxt: add support to set VF rxmode"
@ 2017-06-14 18:01 Yongseok Koh
2017-06-15 16:34 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Yongseok Koh @ 2017-06-14 18:01 UTC (permalink / raw)
To: Ajit Khaparde; +Cc: dev, Ferruh Yigit
Hi, Ajit
It looks you missed some #ifdef/endif when you made newer version for the following patch.
http://dpdk.org/dev/patchwork/patch/25011
Currently, if RTE_LIBRTE_IXGBE_PMD isn't enabled, a compilation error occurs.
> CC cperf_test_latency.o
> LD dpdk-pdump
> app/test-pmd/cmdline.c:13817:27: error: ‘cmd_set_vf_rxmode’ undeclared here (not in a function)
> (cmdline_parse_inst_t *)&cmd_set_vf_rxmode,
> ^
> make[3]: *** [cmdline.o] Error 1
> make[3]: *** Waiting for unfinished jobs....
It is because you moved it out of RTE_LIBRTE_IXGBE_PMD macro.
> @@ -13786,9 +13795,9 @@ cmdline_parse_ctx_t main_ctx[] = {
>
> (cmdline_parse_inst_t *)&cmd_set_macsec_offload_off,
> (cmdline_parse_inst_t *)&cmd_set_macsec_sc,
> (cmdline_parse_inst_t *)&cmd_set_macsec_sa,
>
> - (cmdline_parse_inst_t *)&cmd_set_vf_rxmode,
>
> (cmdline_parse_inst_t *)&cmd_set_vf_traffic,
> #endif
>
> + (cmdline_parse_inst_t *)&cmd_set_vf_rxmode,
>
> (cmdline_parse_inst_t *)&cmd_vf_rate_limit,
> (cmdline_parse_inst_t *)&cmd_vf_rxvlan_filter,
> (cmdline_parse_inst_t *)&cmd_set_vf_mac_addr,
Thanks,
Yongseok
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] Compilation error by "net/bnxt: add support to set VF rxmode"
2017-06-14 18:01 [dpdk-dev] Compilation error by "net/bnxt: add support to set VF rxmode" Yongseok Koh
@ 2017-06-15 16:34 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2017-06-15 16:34 UTC (permalink / raw)
To: Yongseok Koh; +Cc: dev, Ajit Khaparde, Ferruh Yigit
14/06/2017 20:01, Yongseok Koh:
> Hi, Ajit
>
> It looks you missed some #ifdef/endif when you made newer version for the following patch.
> http://dpdk.org/dev/patchwork/patch/25011
>
> Currently, if RTE_LIBRTE_IXGBE_PMD isn't enabled, a compilation error occurs.
Fixed: http://dpdk.org/commit/8bd3bb40
Thanks for reporting
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-15 16:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-14 18:01 [dpdk-dev] Compilation error by "net/bnxt: add support to set VF rxmode" Yongseok Koh
2017-06-15 16:34 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).