From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9CDBCA04DD; Sun, 19 Jan 2020 21:24:05 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3B8D91E34; Sun, 19 Jan 2020 21:24:04 +0100 (CET) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by dpdk.org (Postfix) with ESMTP id 1DE151DBA for ; Sun, 19 Jan 2020 21:24:03 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 0F0DD400; Sun, 19 Jan 2020 15:23:59 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 19 Jan 2020 15:24:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=JNP10TbMldiHGucVnglmRIddzDTwA/TgcsuPgsEns0k=; b=EEc4Kt4ymX+R +WC4KRVqrp4cD1GttT+wUtbP8UxpdbyC78D+SagCH00K6z+QoZTME9UCIb2gqSsZ Axp8mgGjgSsqBDIhW/Of0i9O922z1SLDleaEKLipbFa+p/0xG97l8nx4jROa+ZON TWnOo7N1uFHnYr3TRCey0SnmRBJHaXQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=JNP10TbMldiHGucVnglmRIddzDTwA/TgcsuPgsEns 0k=; b=g3TCHSMFlLX8q8K8UXPTU68eLE7NI4p0aUAHsHAn72ANwyPZGYaHOiztq SqDCV73U6nJO1G/f4arZIJV6rbtGk3n4n1Xh1w3vAmu5lu14EhZ2K/krQzuf/3As zAejEWbv1ufw9RJQ3EEmhqoYZ+s8apgZU6IS9j9tr/WExDFms334X3gxoS/u5Xch ILHddRQ+O8fYp5F+JlimEveVQ8Ogc3iLN1IO5uLn84T1gi7es700sQQ2fpCTeiK2 jbZl972p5Mi566GSdouoFAc6Y5bpn3c9peW3jFKTdLN0B0Av8kt84uXrTKSsibC7 FSI0kzn3VMl+ozS3UhWyPTzxH3ahQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrudefgddufeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B403F80060; Sun, 19 Jan 2020 15:23:58 -0500 (EST) From: Thomas Monjalon To: John Daley , Hyong Youb Kim Cc: ferruh.yigit@intel.com, dev@dpdk.org Date: Sun, 19 Jan 2020 21:23:57 +0100 Message-ID: <1958262.htQpZWrp2x@xps> In-Reply-To: <20200114002451.16248-3-johndale@cisco.com> References: <20200114002451.16248-1-johndale@cisco.com> <20200114002451.16248-3-johndale@cisco.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] net/enic: move macro to the correct file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 14/01/2020 01:24, John Daley: > +#define min_t(type, x, y) ({ \ > + type __min1 = (x); \ > + type __min2 = (y); \ > + __min1 < __min2 ? __min1 : __min2; }) > + > +#define max_t(type, x, y) ({ \ > + type __max1 = (x); \ > + type __max2 = (y); \ > + __max1 > __max2 ? __max1 : __max2; }) Why not using RTE_MIN/RTE_MAX which use typeof? You need to specify a type?