From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] checkpatch script
Date: Tue, 25 Nov 2014 15:28:41 +0100 [thread overview]
Message-ID: <1958676.MmbbGzbMYp@xps13> (raw)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8972685B25A@IRSMSX108.ger.corp.intel.com>
Hi Pablo,
2014-11-25 13:11, De Lara Guarch, Pablo:
> Hi Thomas,
>
> As we have seen the issues we have had on previous patches due to
> checkpatch,
No we have no issues because of checkpatch ;)
It helps us to see some obvious errors.
> would it be possible to include the up-to-date script in the
> repo? I have realized that people either do not check their patches or check
> them with an old version that do not catch some errors that the latest one
> does, so I think this is a problem.
The real problem is to clearly define all the coding rules and adapt
checkpatch to our needs.
> Plus, I think it would be a good idea to mention it in dpdk.org/dev, as this
> is clearly a requirement for merging patches.
Please, let's close DPDK 1.8 first.
Then we'll have to write some documents and tools to make them approved
after necessary discussions/debates.
--
Thomas
next prev parent reply other threads:[~2014-11-25 14:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-25 13:11 De Lara Guarch, Pablo
2014-11-25 14:28 ` Thomas Monjalon [this message]
2014-11-25 14:48 ` De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1958676.MmbbGzbMYp@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).