From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com [209.85.212.180]) by dpdk.org (Postfix) with ESMTP id 98CA33975 for ; Tue, 25 Nov 2014 15:18:14 +0100 (CET) Received: by mail-wi0-f180.google.com with SMTP id n3so1634879wiv.1 for ; Tue, 25 Nov 2014 06:29:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=Hal2NF9eIbI7a5vNRI7rdQXR7Z3VSo7gQ8Apb7zzGzs=; b=b4no8l/aSLXekceEsANVbnxkxG+G58vSiCD9UOe/oBnMU3sKCU3JQ6xvUVLqhwGohh FO5Si0SL/0bXbM+2GoGY7r2/gfbxeHNumi8niN8yRy4yiutBa7asr3+Dy8VaQD5MWvac 6op41TBflMqHxx5awgJUhNqDOZHN8uiaVntlIhWkrpGVTmpgGAN9Do1AtFPnNQe/iB9J voXzpqBPiaPivo6Udf4ADpBsI60DfA5xDpYe7su4EAH+dm1t4amKOhUUjENnEXX2VBg9 CLHsw2raE5YhIvUIMRhFqNM/JKDnKvOVi1jKOv5HBKvFvDAhPmbGxcFCGIpHbV4jYN/g FhZQ== X-Gm-Message-State: ALoCoQmSi3ahakv3l3NIJbMipKSswWMeCBYYFd03s3Qmylg9s0qAPiSpefTWsBti+gc0s8sO7gOD X-Received: by 10.180.35.133 with SMTP id h5mr32830053wij.28.1416925746520; Tue, 25 Nov 2014 06:29:06 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id fl1sm16702136wib.15.2014.11.25.06.29.05 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 25 Nov 2014 06:29:05 -0800 (PST) From: Thomas Monjalon To: "De Lara Guarch, Pablo" Date: Tue, 25 Nov 2014 15:28:41 +0100 Message-ID: <1958676.MmbbGzbMYp@xps13> Organization: 6WIND User-Agent: KMail/4.14.2 (Linux/3.17.2-1-ARCH; KDE/4.14.2; x86_64; ; ) In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] checkpatch script X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Nov 2014 14:18:14 -0000 Hi Pablo, 2014-11-25 13:11, De Lara Guarch, Pablo: > Hi Thomas, > > As we have seen the issues we have had on previous patches due to > checkpatch, No we have no issues because of checkpatch ;) It helps us to see some obvious errors. > would it be possible to include the up-to-date script in the > repo? I have realized that people either do not check their patches or check > them with an old version that do not catch some errors that the latest one > does, so I think this is a problem. The real problem is to clearly define all the coding rules and adapt checkpatch to our needs. > Plus, I think it would be a good idea to mention it in dpdk.org/dev, as this > is clearly a requirement for merging patches. Please, let's close DPDK 1.8 first. Then we'll have to write some documents and tools to make them approved after necessary discussions/debates. -- Thomas