From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 66115592A for ; Mon, 15 Feb 2016 11:04:59 +0100 (CET) Received: by mail-wm0-f51.google.com with SMTP id c200so104884182wme.0 for ; Mon, 15 Feb 2016 02:04:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=iuT0h6LWqs4WK+ImF4AVRLLWJ75+u/LZU6eJwKonmmM=; b=irWrejMuRLdDbybTzGAjSVgrW9Xu4hNriOsLvtdKJVQ2J1eEj9psWZ3D1iUEyqK4fm Tt9wfmo0Pf+Qfgz5K3rFq2cRmcgtO7uR3IZZD1LTCnI4VV4cg4k0OTc4DyKOZRFSSXf+ MB5Vc7lq0DDD7ejMHAa7dHtO1gDshw9WPxUFAtqekmK0GlchA4wQ09/YpIsAXhwyzWV2 VtkUpj7wEIqs2GFeZPqWFpHfORnC8zJmQdIv+brhYuHfBeDaKop6MhjWHbwDNwAAxVHb 5Xt6pw24LvD7ziQLHJ8yMbPS0piTF+xl8dBony1IczW1RDZno5bHn7Xa11gH+EUjvVFS u3nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=iuT0h6LWqs4WK+ImF4AVRLLWJ75+u/LZU6eJwKonmmM=; b=IAmuJRsPgePZiC2FgvOInkelcc6ulxup0fwb4GnvDJHxz0PoC9m27+HOBk5jUWKCij e8TZvqstP0oqU4BdKqa8NuhAUj6ZYK4gqQ1qvilOwFXduKNoiG2q82Ese+kzN7PXlTTr V/3bafIOTCcJOQ5GA0ctpWmiRLnKi8WlK+f/z9Idko398YfuBe/lGEEglFbwjU1zzXZs eAlh21yrQsIrKDYPPqv2Lk7zT4WDop55ry3K2QcEONSbuA6PThfZVmaNUxJ8ckjwjyQQ 4jFo5mFUz22yUKi3RZcQ7f1mTOffPL3xewYOe1D4xO+6EFS9a6Tb1amzoh01L6tM4Vhf iTmA== X-Gm-Message-State: AG10YOTM3Lq2xgMZgP36NTBX4vt9vF/iu+6Zlw4dCeIhTXKxRG2n7l+f5RrJWgY2xSOZUkBH X-Received: by 10.28.179.130 with SMTP id c124mr12013975wmf.76.1455530699217; Mon, 15 Feb 2016 02:04:59 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id ei9sm24537135wjd.40.2016.02.15.02.04.57 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 15 Feb 2016 02:04:58 -0800 (PST) From: Thomas Monjalon To: "Lu, Wenzhuo" Date: Mon, 15 Feb 2016 11:03:27 +0100 Message-ID: <1958817.fmrgW3e0Zp@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09090342A92F@shsmsx102.ccr.corp.intel.com> References: <1452496044-17524-1-git-send-email-wenzhuo.lu@intel.com> <2601191342CEEE43887BDE71AB97725836B03304@irsmsx105.ger.corp.intel.com> <6A0DE07E22DDAD4C9103DF62FEBC09090342A92F@shsmsx102.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 5/6] ixgbe: support VxLAN & NVGRE TX checksum off-load X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Feb 2016 10:04:59 -0000 2016-02-15 05:32, Lu, Wenzhuo: > From: Ananyev, Konstantin > > From reading X550 spec, I don't really understand what for we need to specify is > > it GRE or VXLAN packet, so probably we don't need that flag for now at all? > The reason is we need to set the tunnel type in the Advanced Transmit Data Descriptor. Why don't we use packet type? > > If we really do, might bw worth to organise it like KT_TX_L4_CKSUM (as enum) > > and reserve few values for future expansion (2 or 3 bits?). > Now there're only VxLAN and NVGRE supported. So, only 1 bit is occupied for that. Not sure if more types will be supported in the future. Any suggestions? Thanks. Yes there can be a lot of tunnel types. Please check RTE_PTYPE_TUNNEL_*