From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 9CB3A2B84 for ; Wed, 5 Apr 2017 16:46:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1491403567; x=1522939567; h=subject:to:references:cc:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=ZWRBu89imEDTDev3S/Y8v69fbfh7uuKZ/zqcaEnFuhw=; b=p2qZyFTsiL2lnWRNXk3DxfWPUqgkjY2OSJjSX9FbnNtuS2dMcPoKn5p7 oE5YYPjaB2UInCeuvwH0xMyfZwL8Qw==; Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Apr 2017 07:46:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,279,1486454400"; d="scan'208";a="84771637" Received: from mhanley-mobl.ger.corp.intel.com (HELO [10.252.31.80]) ([10.252.31.80]) by fmsmga005.fm.intel.com with ESMTP; 05 Apr 2017 07:46:05 -0700 To: Thomas Monjalon References: <1490907662-27666-1-git-send-email-remy.horton@intel.com> <1490907662-27666-2-git-send-email-remy.horton@intel.com> <165712131.qiFBceb8LK@xps13> Cc: dev@dpdk.org From: Remy Horton Organization: Intel Shannon Limited Message-ID: <195ebf71-69a7-fca2-ce95-8912ad7ef51a@intel.com> Date: Wed, 5 Apr 2017 15:46:04 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <165712131.qiFBceb8LK@xps13> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v14 1/6] lib: add information metrics library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Apr 2017 14:46:08 -0000 On 05/04/2017 14:39, Thomas Monjalon wrote: > 2017-03-30 22:00, Remy Horton: >> --- a/mk/rte.app.mk >> +++ b/mk/rte.app.mk [..] >> +_LDLIBS-$(CONFIG_RTE_LIBRTE_METRICS) += -lrte_metrics > > It should not be added here in --whole-archive as it is not going to be > used by plugins (drivers). > > I suggest moving it upper with rte_jobstats. Ok. As an aside, there seems to have been recent changes to the build system, so I suspect there might be a few redundant Makefile additions lying around the patchset. ..Remy