From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/3] uio: fix irq handling with igb_uio
Date: Wed, 13 May 2015 11:31:31 +0200 [thread overview]
Message-ID: <1965571.qvjumJN0Zx@xps13> (raw)
In-Reply-To: <20150430162703.GA5972@bricha3-MOBL3>
2015-04-30 17:27, Bruce Richardson:
> On Tue, Apr 28, 2015 at 09:36:38AM -0700, Stephen Hemminger wrote:
> > The introduction of uio_pci_generic broke interrupt handling with
> > igb_uio. The igb_uio device uses the kernel read/write method to
> > enable disable IRQ's; the uio_pci_generic has to use PCI intx
> > config read/write to enable disable interrupts.
> >
> > Since igb_uio uses MSI-X the PCI intx config read/write won't
> > work.
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Fixes: c112df6875a5 ("eal/linux: toggle interrupt for uio_pci_generic")
Applied this fix without the rest of the series (incomplete enhancements).
Thanks for the good work on pci interrupts.
next prev parent reply other threads:[~2015-05-13 9:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-28 16:36 [dpdk-dev] [PATCH 0/3] eal: uio irq fixes and enhancements Stephen Hemminger
2015-04-28 16:36 ` [dpdk-dev] [PATCH 1/3] uio: fix irq handling with igb_uio Stephen Hemminger
2015-04-30 16:27 ` Bruce Richardson
2015-05-13 9:31 ` Thomas Monjalon [this message]
2015-04-28 16:36 ` [dpdk-dev] [PATCH 2/3] pci: add ability to read/write config space Stephen Hemminger
2015-04-28 16:36 ` [dpdk-dev] [PATCH 3/3] eal: use pci_uio_read/write config to enable/disable INTX Stephen Hemminger
2015-05-12 20:02 ` [dpdk-dev] [PATCH 0/3] eal: uio irq fixes and enhancements Thomas Monjalon
2015-05-13 8:57 ` Bruce Richardson
2015-05-13 9:32 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1965571.qvjumJN0Zx@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).