Re: [dpdk-dev] [PATCH v2]:rte_timer:timer lag issue correction

[Thomas Monjalon <thomas.monjalon@6wind.com>]

Hi,

2016-09-21 17:08, Karmarkar Suyash:
> Hello,
> 
> I corrected the fixes line, Can you please review the change and if no further comments can you please let me know the next steps. Thanks.

The Fixes lines is still not correct. The id ba885531ac26 do not exist.
Please check your patch with scripts/check-git-log.sh.
Karmarkar, it is preferred to use --in-reply-to when sending a new version.

Please Robert, could you check it is a right fix?
Thanks

> --- a/lib/librte_timer/rte_timer.c
> +++ b/lib/librte_timer/rte_timer.c
> @@ -613,7 +613,7 @@ void rte_timer_manage(void)
>  			status.owner = (int16_t)lcore_id;
>  			rte_wmb();
>  			tim->status.u32 = status.u32;
> -			__rte_timer_reset(tim, cur_time + tim->period,
> +			__rte_timer_reset(tim, tim->expire + tim->period,
>  				tim->period, lcore_id, tim->f, tim->arg, 1);
>  			rte_spinlock_unlock(&priv_timer[lcore_id].list_lock);
>  		}