From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id EF4A95589 for ; Wed, 21 Sep 2016 22:03:40 +0200 (CEST) Received: by mail-wm0-f45.google.com with SMTP id l132so288618047wmf.0 for ; Wed, 21 Sep 2016 13:03:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=JYXZRSGIizabMIsC+d+wDF1RLgLjJRKny9ytE85pw3U=; b=Dc7nf7gzVahg4lExtaDZqkgKoLAKQJXUcjbA+su9ikyo+y3ZOBMhGtQOQ+ixyjho6Q X7qpCVz48oaFL2ykhxsr5PYoZa9bUnO5oAE2tJGWQ43IobFJVBf7nz2+HOPgycYbpDaK GJhVFJrBMr5xl5isGSwjQn9JDEnqz5jhqJ+M/b9P6O2MAccq7ScDH4uzMa0lzLFf9Iz8 EbD5F0tY4k87Q+4n1RYw7znTtnnqanTW7d6KCYXzxM5fi2ackigO50VsY0PIiMykqwUS 6/72BEBjYfEzxFH3T3bLOkVTkYApgn2yT4M88fqp6FgM5GRGzwXj0FlQM5vQLbvEIjYF KtJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=JYXZRSGIizabMIsC+d+wDF1RLgLjJRKny9ytE85pw3U=; b=UHgGtqGe7Pah1WbeuZlsI4hdZfmAfqJNJOQ9NUPTYnhadWN1QU0Zx2Iq7CAXt4iIAp iCwTZu4KkuTa5ew4C9JUBdkV1hN2OoxOyT394WA+9YrFp604431q4WaHtZzH9MeSBSfl gBLQNIKO/mVfKmV23rO4anMn8NBYnO1Rz3sMdWFXPv+IhkOikDFkYmc2Ip/iyIy4XQYd r2OiSJtBT/S9mItytukripndvwF4RNDmtl2C3v0FZzhOXcbWQr81EjqAMyXxwcwgdGxx 8BJ27y98AHLuO0gE9NfFJrThH31SfwCghk2qBGSm1oZz/j7Io09zhE4wotZ4Y9zIkUXP ioBQ== X-Gm-Message-State: AE9vXwM5ZZkYIgGp38Af7lsWw4VvWL9kT7OsHWFEAsP//+LfIAFmN9c04n6y08xc2UJpQ2jb X-Received: by 10.194.135.76 with SMTP id pq12mr33599847wjb.114.1474488220704; Wed, 21 Sep 2016 13:03:40 -0700 (PDT) Received: from xps13.localnet (guy78-1-82-235-116-147.fbx.proxad.net. [82.235.116.147]) by smtp.gmail.com with ESMTPSA id n131sm34197713wmd.3.2016.09.21.13.03.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Sep 2016 13:03:39 -0700 (PDT) From: Thomas Monjalon To: Karmarkar Suyash , rsanford@akamai.com Cc: dev@dpdk.org, reshma.pattan@intel.com Date: Wed, 21 Sep 2016 22:03:38 +0200 Message-ID: <19661851.bryX1Po3Jn@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <20160916160222.12956-1-skarmarkar@sonusnet.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2]:rte_timer:timer lag issue correction X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Sep 2016 20:03:41 -0000 Hi, 2016-09-21 17:08, Karmarkar Suyash: > Hello, > > I corrected the fixes line, Can you please review the change and if no further comments can you please let me know the next steps. Thanks. The Fixes lines is still not correct. The id ba885531ac26 do not exist. Please check your patch with scripts/check-git-log.sh. Karmarkar, it is preferred to use --in-reply-to when sending a new version. Please Robert, could you check it is a right fix? Thanks > --- a/lib/librte_timer/rte_timer.c > +++ b/lib/librte_timer/rte_timer.c > @@ -613,7 +613,7 @@ void rte_timer_manage(void) > status.owner = (int16_t)lcore_id; > rte_wmb(); > tim->status.u32 = status.u32; > - __rte_timer_reset(tim, cur_time + tim->period, > + __rte_timer_reset(tim, tim->expire + tim->period, > tim->period, lcore_id, tim->f, tim->arg, 1); > rte_spinlock_unlock(&priv_timer[lcore_id].list_lock); > }