From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 37B427D0B for ; Mon, 4 Sep 2017 18:06:22 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Sep 2017 09:06:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,475,1498546800"; d="scan'208";a="125446858" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.57]) ([10.237.220.57]) by orsmga004.jf.intel.com with ESMTP; 04 Sep 2017 09:06:20 -0700 To: Jan Blunck , dev@dpdk.org References: <20170711232512.54641-1-jblunck@infradead.org> <20170714211213.34436-1-jblunck@infradead.org> <20170714211213.34436-5-jblunck@infradead.org> From: Ferruh Yigit Message-ID: <196ef558-7107-b490-6892-75d85a40a18c@intel.com> Date: Mon, 4 Sep 2017 17:06:18 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170714211213.34436-5-jblunck@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 04/15] devargs: deprecate enum rte_devtype based functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Sep 2017 16:06:24 -0000 On 7/14/2017 10:12 PM, Jan Blunck wrote: > The enum rte_devtype will need to get extended every time we add a bus. > Mark all related functions as deprecated for 17.11. > > Signed-off-by: Jan Blunck > --- > doc/guides/rel_notes/deprecation.rst | 7 +++++++ > lib/librte_eal/common/include/rte_devargs.h | 3 +++ > 2 files changed, 10 insertions(+) > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > index 257dcba32..0c763d522 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -64,3 +64,10 @@ Deprecation Notices > be removed in 17.11: > > - ``rte_eal_parse_devargs_str``, replaced by ``rte_eal_devargs_parse`` > + > +* devargs: An API/ABI change is planed for 17.11 for ``struct rte_devargs`` to > + remove ``enum rte_devtype`` so that starting from 17.08 the following > + functions are deprecated: > + > + - ``rte_eal_devargs_add`` > + - ``rte_eal_devargs_type_count`` This also seems already applied. > diff --git a/lib/librte_eal/common/include/rte_devargs.h b/lib/librte_eal/common/include/rte_devargs.h > index 62dd67bff..41db817cc 100644 > --- a/lib/librte_eal/common/include/rte_devargs.h > +++ b/lib/librte_eal/common/include/rte_devargs.h > @@ -53,6 +53,7 @@ extern "C" { > #include > > /** > + * @deprecated Although these "@deprecated" notes not applied. > * Type of generic device > */ > enum rte_devtype { > @@ -139,6 +140,7 @@ rte_eal_devargs_parse(const char *dev, > struct rte_devargs *da); > > /** > + * @deprecated > * Add a device to the user device list > * > * For PCI devices, the format of arguments string is "PCI_ADDR" or > @@ -163,6 +165,7 @@ rte_eal_devargs_parse(const char *dev, > int rte_eal_devargs_add(enum rte_devtype devtype, const char *devargs_str); > > /** > + * @deprecated > * Count the number of user devices of a specified type > * > * @param devtype >