From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 6CD0BA0F2 for ; Wed, 2 Aug 2017 16:32:40 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id ED4782095B; Wed, 2 Aug 2017 10:32:39 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Wed, 02 Aug 2017 10:32:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=qIM9HQoqZY/EoFC DKqeus/XAtNDNZj/W2E7zUvSbTNE=; b=LBoEYNgdUKtVdEbanl2Qe/fWqHwNkV2 0VuCMbCfRm9Ad/jIvgv1WNb0HaRuIizjtNhcmjPDY6OOET0KjPnkcNE+eYU/qJ1j 6pPXl2hTjKnDH6KKyzQ5BcMAOenV2r4ge3T+AN/GJu45cNBZLrcLkNjMEwgZkywJ 8kgktHc7M9gw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=qIM9HQoqZY/EoFCDKqeus/XAtNDNZj/W2E7zUvSbTNE=; b=TopB+AAJ I5JzdanFjOpTaQtlHi/yNSces1ybrBRYwMeYrNQQ4mgZ7MyuXiiMRI1GSKnLgPqk LgLUCECEgF+faz6hq7wpeCMhOOqxF9gpS1iUyzdl0tDavdIohOQcLP+YgtshP7hj tYFBaAuUWHqGo9JgJ1oborD1iOhN7xtV4uAqf/J0yWda8VryWpNWM20iDWZKQ4Ql Cmlq1j46ppRz1vRbKHxu9Itacy0xujYptaRNbhLKchwgcfLlwkYHoTftiPrZ/om+ 0IZ2IgnEPbTCYKAYHx0SIVUDSmtrXuzTu1fOT/eQTSM9OEJaRcn7ZaKDcVBAClp2 dbRkfj/SOpRp1w== X-ME-Sender: X-Sasl-enc: TEE/Gj1B70N4D3GHqO0+gIFJiKNFGxjRxSabV51vsH88 1501684359 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 9B60B7E5EC; Wed, 2 Aug 2017 10:32:39 -0400 (EDT) From: Thomas Monjalon To: Gaetan Rivet Cc: dev@dpdk.org Date: Wed, 02 Aug 2017 16:32:38 +0200 Message-ID: <1970205.aClgWgp9Kr@xps> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] devargs: fix scan mode configuration in add X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2017 14:32:40 -0000 02/08/2017 10:55, Gaetan Rivet: > When adding rte_devargs to the list, a check is performed on the > intended bus that should use this rte_devargs. This bus configuration is > for the time being only set once when the first rte_devargs is added to > it. If the bus configuration has previously been set, then the rte_devargs > insertion fails. Sorry, I don't understand which logic is changed :) Maybe it would be easier with an example? > Failure occuring upon detection of the set configuration is an API > change. While rules will certainly be enforced in the next rte_devargs > API, none were previously enforced and this should be respected until > this API is deprecated. > > The bus configuration is meant to evolve soon, but in the meantime it > should strictly follow the current rte_eal_devargs_add API. > > The rte_devargs unit tests are failing due to this API change. Revert > this evolution, it will be reintroduced properly in the next release if > necessary. So this is a revert. I think the title start with "revert" instead of "fix" as you seem to go back to the old behaviour.