From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id D3E2A56A1 for ; Sun, 14 Apr 2019 20:29:14 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 7E7F821EAF; Sun, 14 Apr 2019 14:29:14 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 14 Apr 2019 14:29:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=dyRg7LWamIbNBvaHrZE2729tuxYMboS01aZeFwMjMqQ=; b=VgKvyZxvN8J7 0Zd8d/xNyaw85piZGTJRH9mp/4Jz2R4FGfeuaYtGAFZp5gxR4WAryQfxdZvFfdgX r3+ffLeaxB74TpdDepabJV20UvkAjo7wgj+/6//cv8fsJcuV7aVzZrCEO6JiWsaT QmtkrdAgt9SA6h2S/XALmZPDxxtmgas= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=dyRg7LWamIbNBvaHrZE2729tuxYMboS01aZeFwMjM qQ=; b=UzdLrC89KaSEdvWAG2T/0/zs5VB+PUTLp9sIkZCiV6oQt2lz/zUxEhk24 EA0fpiCyk89zUbYpK4fP+nqWZCKPIvb7tSK1Q6zipN0Ze/363mdL6Xlv/u2hqYtP 6CO5Keh3FvjOfr9DnO2uJ3q/teFlvqoitmUfSdrnny7WT4fQl5sCeGmTRWNZ5jZZ piyx90sV/S0Maqq8ZJmqMSYsFRrvuPVE1psjb72CzjCGmETMVqaR+wVOEmRaNHa8 j6+f9xlryjET8joZDu5qKaKa2LWUoa0MEvAr4HcemWfS+OQZYp89KRGNvbYo8f8a t5T5vTP7vjnkDvv59qJ46++Fo0Xug== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrvdejgdduvdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D6A941030F; Sun, 14 Apr 2019 14:29:12 -0400 (EDT) From: Thomas Monjalon To: Jerin Jacob Kollanukkaran Cc: Pavan Nikhilesh Bhagavatula , "dev@dpdk.org" , "jerinjacobk@gmail.com" , "yskoh@mellanox.com" , "bruce.richardson@intel.com" Date: Sun, 14 Apr 2019 20:29:10 +0200 Message-ID: <19704156.6GcstIa4Ju@xps> In-Reply-To: References: <20190406142737.20091-1-jerinj@marvell.com> <1966190.OdWs8lNuHB@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v8 2/4] meson: add infra to support machine specific flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Apr 2019 18:29:15 -0000 14/04/2019 20:19, Jerin Jacob Kollanukkaran: > From: Thomas Monjalon > > 14/04/2019 16:40, Pavan Nikhilesh Bhagavatula: > > > Hi Thomas, > > > > > > There is no guarantee of primary part number (machine names) uniqueness > > between implementors. > > > > I think we don't speak the same language :) By machine name, I mean what we > > set in RTE_MACHINE, like octeontx2. > > As you know, The system probes "implementor_id" and "implementor_pn" > Values. There is nothing like machine name in meson and in order to keep > Synergy with native build, we need to just follow, "implementor_id" > and "implementor_pn". Now, it is possible to have "implemetor_id" to > "implementor_pn" to machine name lookup but Unlike, "make" based > Build system, meson supports supporting a lot of machines(like RTE_MACHINE), > with that structure. So converting to another intermediate called "machine string" > will have more overhead IMO. We already have this string with RTE_MACHINE. You already set RTE_MACHINE based on id and pn. I don't see any overhead. Anyway, no need to discuss it more without any real code. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 5EB44A00E6 for ; Sun, 14 Apr 2019 20:29:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2F52C56A3; Sun, 14 Apr 2019 20:29:16 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id D3E2A56A1 for ; Sun, 14 Apr 2019 20:29:14 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 7E7F821EAF; Sun, 14 Apr 2019 14:29:14 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 14 Apr 2019 14:29:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=dyRg7LWamIbNBvaHrZE2729tuxYMboS01aZeFwMjMqQ=; b=VgKvyZxvN8J7 0Zd8d/xNyaw85piZGTJRH9mp/4Jz2R4FGfeuaYtGAFZp5gxR4WAryQfxdZvFfdgX r3+ffLeaxB74TpdDepabJV20UvkAjo7wgj+/6//cv8fsJcuV7aVzZrCEO6JiWsaT QmtkrdAgt9SA6h2S/XALmZPDxxtmgas= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=dyRg7LWamIbNBvaHrZE2729tuxYMboS01aZeFwMjM qQ=; b=UzdLrC89KaSEdvWAG2T/0/zs5VB+PUTLp9sIkZCiV6oQt2lz/zUxEhk24 EA0fpiCyk89zUbYpK4fP+nqWZCKPIvb7tSK1Q6zipN0Ze/363mdL6Xlv/u2hqYtP 6CO5Keh3FvjOfr9DnO2uJ3q/teFlvqoitmUfSdrnny7WT4fQl5sCeGmTRWNZ5jZZ piyx90sV/S0Maqq8ZJmqMSYsFRrvuPVE1psjb72CzjCGmETMVqaR+wVOEmRaNHa8 j6+f9xlryjET8joZDu5qKaKa2LWUoa0MEvAr4HcemWfS+OQZYp89KRGNvbYo8f8a t5T5vTP7vjnkDvv59qJ46++Fo0Xug== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrvdejgdduvdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D6A941030F; Sun, 14 Apr 2019 14:29:12 -0400 (EDT) From: Thomas Monjalon To: Jerin Jacob Kollanukkaran Cc: Pavan Nikhilesh Bhagavatula , "dev@dpdk.org" , "jerinjacobk@gmail.com" , "yskoh@mellanox.com" , "bruce.richardson@intel.com" Date: Sun, 14 Apr 2019 20:29:10 +0200 Message-ID: <19704156.6GcstIa4Ju@xps> In-Reply-To: References: <20190406142737.20091-1-jerinj@marvell.com> <1966190.OdWs8lNuHB@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v8 2/4] meson: add infra to support machine specific flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190414182910.T4XanEui9b_VPvIr9dJWYKkxRt6V8vWZ8ZZ4wP_mGVk@z> 14/04/2019 20:19, Jerin Jacob Kollanukkaran: > From: Thomas Monjalon > > 14/04/2019 16:40, Pavan Nikhilesh Bhagavatula: > > > Hi Thomas, > > > > > > There is no guarantee of primary part number (machine names) uniqueness > > between implementors. > > > > I think we don't speak the same language :) By machine name, I mean what we > > set in RTE_MACHINE, like octeontx2. > > As you know, The system probes "implementor_id" and "implementor_pn" > Values. There is nothing like machine name in meson and in order to keep > Synergy with native build, we need to just follow, "implementor_id" > and "implementor_pn". Now, it is possible to have "implemetor_id" to > "implementor_pn" to machine name lookup but Unlike, "make" based > Build system, meson supports supporting a lot of machines(like RTE_MACHINE), > with that structure. So converting to another intermediate called "machine string" > will have more overhead IMO. We already have this string with RTE_MACHINE. You already set RTE_MACHINE based on id and pn. I don't see any overhead. Anyway, no need to discuss it more without any real code.