From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DC9BEA0C55; Wed, 13 Oct 2021 13:55:36 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C1650410DA; Wed, 13 Oct 2021 13:55:36 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id 8F3A140E64; Wed, 13 Oct 2021 13:55:34 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 40A915C01EA; Wed, 13 Oct 2021 07:55:32 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 13 Oct 2021 07:55:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= GylinqTz131kfxUnDackODxM7W1QP5BXZuUcLDjAWKI=; b=eYFi2CZXYtsSM0v5 WNGz2+p7maIGodXXs9oiigACRuHtlbhtbLzTC6y3tS9/H8KRMOgFClwePKB8OZDD 98jrl7igV/bgnxm4XWMQeghZdfFEhtdW1zlvz3LzJbm9hVGvcz4H0M5CbEv2NRpM TMSwVeAMRZj6CTh4PezcQBGOXZO4D+GmjVrPQityEtH3QYm1OVmb0l+1DO6m5ZLC M7jwMkN4MPJh1Di1ks700g8SBtNdpfUa7wH+81EAl2/6BpiOof3d9rAsBOCaeXzT Sh89PrqSmhYQl/sb5aCaI7JV3yPUnMqPnwMJJkPR3joDabu+EqL5lDX77mjYQX6g EivpBA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=GylinqTz131kfxUnDackODxM7W1QP5BXZuUcLDjAW KI=; b=blZq2UjKepNTEh8/UNdkquiesfERbBzQ5dih5TRGvOFC9St2p2LjuhQWb ZGWTeneC2yMFeGoC6oNpSVnnzqB99WOBkIjsMZHj5DNaOm2yMGDS4zHIyx2E0lLJ wOsTpneTLWwK1kosVeVPIAZG/nc4mbrXv68dKeeSNTGxVjCnRw+EXBcXXjSKGihF MRsiCQZjeo20qOgYCuh4HRYS1DyXJN5/kLWm7XO5bnNASSJM4CYJlfweyu6e6k5k czS4Qqn9UYH+ZbnxAYt87qWdXmSN02moG2fdjylzkId2Z3VVifcHXg19zGHN3obw xsktQOwo53dWtGtX8Cbx2bhkIIYLA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvddutddggeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 13 Oct 2021 07:55:30 -0400 (EDT) From: Thomas Monjalon To: Long Li Cc: dev@dpdk.org, Stephen Hemminger , Jonathan Erb , stable@dpdk.org Date: Wed, 13 Oct 2021 13:55:27 +0200 Message-ID: <1973433.8l5BURKI8a@thomas> In-Reply-To: <1632948370-25668-1-git-send-email-longli@linuxonhyperv.com> References: <1632948370-25668-1-git-send-email-longli@linuxonhyperv.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [Patch v2] bus/vmbus: map to the correct ring buffer addresses for the secondary process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 29/09/2021 22:46, longli@linuxonhyperv.com: > From: Long Li > > The driver code had wrong assumption that all the addresses to ring buffers > in the secondary process are the same as those in the primary process. This > is not always correct as the channels could be mapped to different > addresses in the secondary process. > > Fix this by keeping track of all the mapped addresses from the primary > process in the shared uio_res, and have second process map to the same > addresses. > > Fixes: 831dba47bd36 ("bus/vmbus: add Hyper-V virtual bus support") > > Reported-by: Jonathan Erb > Cc: stable@dpdk.org > Signed-off-by: Long Li You forgot this ack from v1: Acked-by: Stephen Hemminger Applied, thanks