From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AE4C3A00B8; Sun, 27 Oct 2019 18:21:35 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 496A01BED5; Sun, 27 Oct 2019 18:21:34 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 3EF37271 for <dev@dpdk.org>; Sun, 27 Oct 2019 18:21:32 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 95937218C1; Sun, 27 Oct 2019 13:21:31 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 27 Oct 2019 13:21:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=k8WGTfTV9BtHPR/l2u0nrllOw5i2OFSMy0LM5whslaY=; b=p5bJ3Kqkem+C 7lXbPnqDZt5ngP0NIalWk9qwFnmfSzIYN3qRc0GxLpzJraEsaTA/nEJmiJ/HBDAA a7Z3GOwJGU3VWQwLyxdkb05VtvmFk2wNVahYEdILLUv1jSIOBQfTwiudOM1PUAUQ 0iH7V6helvxeFNhTcp3Q2OiKr9Z4U0w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=k8WGTfTV9BtHPR/l2u0nrllOw5i2OFSMy0LM5whsl aY=; b=NuKrMD3r71luqw4TGff84UMBVD9U1YXw6E6v3OfUaUai+dcw6uphlP0dj evSKyej2h4zYS2kiR867QF3ChG9vHT7w8+2TfcYbRXdiz9yfQdcLy+SiMn6GxzPN ZWbcSjG8dSNzBe9RLx1g+OvbrnHPBNKO9JnrXxb6jD3mjn1cnh+hxtMo39klG6mn Sb5bJ7pjbnqWrSx4NPP7OQ7EVgSWjSyIlm5GO1+88dMOln9aHmEzmDW30peQkdCR WrEn0/N4hd1nx3igwxro/WccYR+2AWMX6hk3Ne6sGKoLFfIc92fNu4A0M7GfGnRl 8c5ENiQT+w5n0jeDrK4gIt3n0hDwA== X-ME-Sender: <xms:GtK1Xew6OhVPRcQWYFsb4yDt4aizArJQXGtw8hKbqNz43b53E9bzAg> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrleejgddutdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff homhgrihhnpehhuhgrrhhmrdgtohhmnecukfhppeejjedrudefgedrvddtfedrudekgeen ucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth enucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: <xmx:G9K1XUXDFPulD0WBf52Hu7abZLERTl7o8Ep7iPJKFqjezd04Pyq_0w> <xmx:G9K1XTN7YLmOEolZiDW3hwQqrnRdnahnYctek6LCgSksC5tbfPrxZg> <xmx:G9K1XccxLTOLu0jTP7m3uJsb9sSBKBdsmIVBXSW5HhqSYp6_eU42ZQ> <xmx:G9K1XVhmqNqqJrMGvkf1Rptfrl5zs3cc8Vmz6rCaz9vZSSx6h8jhTw> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D471480059; Sun, 27 Oct 2019 13:21:29 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Feifei Wang <feifei.wang@arm.com> Cc: dev@dpdk.org, gavin.hu@arm.com, ruifeng.wang@arm.com, phil.yang@arm.com, Honnappa.Nagarahalli@arm.com, nd@arm.com, konstantin.ananyev@intel.com Date: Sun, 27 Oct 2019 18:21:28 +0100 Message-ID: <1973460.tJ4aIHWnQC@xps> In-Reply-To: <1565772870-24903-1-git-send-email-feifei.wang@arm.com> References: <1565772870-24903-1-git-send-email-feifei.wang@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] examples/l3fwd: prefetch the content of the next packet X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> +Cc Konstantin 14/08/2019 10:54, Feifei Wang: > The cache-misses problem is very serious when the function > lpm_cb_parse_ptype is called to read the content of packets. That is > because the contents of packages previously stored in the cache are > overwritten by the following instructions or variables. > Thus the prefetch order can be used to prefetch the next packet into > the cache to avoid CPU spending too much time on it. > > On Octeon TX platform with built-in NIC, 12% performance gain was > measured by running RFC2544 NDR test with l3fwd. Furthermore, the > cache-misses event of the function lpm_cb_parse_ptype was reduced by > 20%, and the CPU task-clock of it dropped from 16.49% to 11.3%, based > on the forwarding test for one minute with the 64B packet. > On the dpaa2 platform, no performance improvement nor drop were seen > with this patch by running RFC2544 NDR test with l3fwd. > On the x86 platform, 15.7% performance gain was measured by running > RFC2544 NDR test with l3fwd. > > Signed-off-by: Feifei Wang <feifei.wang@arm.com> > Reviewed-by: Gavin Hu <gavin.hu@arm.com> > Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com> > Reviewed-by: Phil Yang <phil.yang@arm.com> Let's test this "improvement" with 19.11-rc1. If a drawback is seen, the patch can be reverted. Applied, thanks