From: Thomas Monjalon <thomas@monjalon.net>
To: "Varghese, Vipin" <vipin.varghese@intel.com>
Cc: dev@dpdk.org, "Van Haaren, Harry" <harry.van.haaren@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3] service: fix memory leak by rte_service_init
Date: Fri, 26 Jan 2018 17:54:45 +0100 [thread overview]
Message-ID: <1976827.tOLhCWFkBG@xps> (raw)
In-Reply-To: <E923DB57A917B54B9182A2E928D00FA651004DFB@IRSMSX102.ger.corp.intel.com>
26/01/2018 16:20, Van Haaren, Harry:
> > From: Varghese, Vipin
> > Sent: Friday, January 26, 2018 8:56 PM
> > To: Van Haaren, Harry <harry.van.haaren@intel.com>; dev@dpdk.org
> > Cc: stable@dpdk.org; Varghese, Vipin <vipin.varghese@intel.com>
> > Subject: [PATCH v3] service: fix memory leak by rte_service_init
> >
> > The rte_service_finalize routine checks if service is initialized
> > or not. If yes; releases internal memory for services and lcore
> > states are freed. This routine is to be invoked at end of application
> > termination.
> >
> > Fixes: 21698354c832 ("service: introduce service cores concept")
> > Cc: harry.van.haaren@intel.com
> >
> > Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
>
>
> Thanks Vipin!
>
> @Stable - this patches allows for fixes secondary processes that
> init and quit often, to avoid leaking hugepages memory. As such,
> I think it is valuable to include in stable.
>
> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
Applied, thanks
prev parent reply other threads:[~2018-01-26 16:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-31 14:46 [dpdk-dev] [PATCH v1] " Vipin Varghese
2018-01-08 10:17 ` Van Haaren, Harry
2018-01-08 14:40 ` Bruce Richardson
2018-01-11 18:20 ` [dpdk-dev] [PATCH v2] " Vipin Varghese
2018-01-25 22:10 ` Thomas Monjalon
2018-01-26 10:10 ` Van Haaren, Harry
2018-01-26 13:18 ` Thomas Monjalon
2018-01-26 20:55 ` [dpdk-dev] [PATCH v3] " Vipin Varghese
2018-01-26 15:20 ` Van Haaren, Harry
2018-01-26 16:54 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1976827.tOLhCWFkBG@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=stable@dpdk.org \
--cc=vipin.varghese@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).