From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id A5EC91B350; Fri, 26 Jan 2018 17:55:28 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 281FC20F60; Fri, 26 Jan 2018 11:55:28 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Fri, 26 Jan 2018 11:55:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=gpJXBeSdlHjZrkCBtSm3eUCiOU dsGMMfm/5DLqCC51c=; b=aJUAuuZkL4OhKyuOM0pQWqrzxy26FDSALEoYovwzSF 3hNfNZraiRHywYVyWFVmwSIU0h1+OuAezViJfOp1mn9oeWFXSibqWYPDPuTsaTNL sZi0qC6gXW7uH8OG1UCO0yPys0DuGoLmUu586Imahe+Vb7wGfAmRhqykjhcYvpNT o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=gpJXBe SdlHjZrkCBtSm3eUCiOUdsGMMfm/5DLqCC51c=; b=FUW7XK7FKPlYjw734aezd2 z1IRPTeHnNgYQFHyH7/rANfaCdtPj718lLbjcQd2TOHpJJ3J5JbxY4lA4W/i22iG wW+8zd6usJ19fPoEWry7/VeYLDU3Hj4afVUZHbVQdJ4nbmOZ/vnkQrB0y2o1AGxj 8+3Zu7QQS2G8CA6RSCHKOnm7ux0SHjVOs5Vys6Pjnx+N5Ej/nmYc4u1iBRTqySwV XE10wPnb+ZoKtL4hgaciRRDcXwGkUBFryae1aN0LOpqP+tfrkpb+nA4ZxYIDwit1 LFZKxu8i+c8CwOSsY46Fk3C+3rP4nqy54Fc+37/i3zwS32CyvtBR8b4SCauxgGvQ == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id C1C727E2E5; Fri, 26 Jan 2018 11:55:27 -0500 (EST) From: Thomas Monjalon To: "Varghese, Vipin" Cc: dev@dpdk.org, "Van Haaren, Harry" , "stable@dpdk.org" Date: Fri, 26 Jan 2018 17:54:45 +0100 Message-ID: <1976827.tOLhCWFkBG@xps> In-Reply-To: References: <1515694853-7949-1-git-send-email-vipin.varghese@intel.com> <1517000136-24802-1-git-send-email-vipin.varghese@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] service: fix memory leak by rte_service_init X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jan 2018 16:55:28 -0000 26/01/2018 16:20, Van Haaren, Harry: > > From: Varghese, Vipin > > Sent: Friday, January 26, 2018 8:56 PM > > To: Van Haaren, Harry ; dev@dpdk.org > > Cc: stable@dpdk.org; Varghese, Vipin > > Subject: [PATCH v3] service: fix memory leak by rte_service_init > > > > The rte_service_finalize routine checks if service is initialized > > or not. If yes; releases internal memory for services and lcore > > states are freed. This routine is to be invoked at end of application > > termination. > > > > Fixes: 21698354c832 ("service: introduce service cores concept") > > Cc: harry.van.haaren@intel.com > > > > Signed-off-by: Vipin Varghese > > > Thanks Vipin! > > @Stable - this patches allows for fixes secondary processes that > init and quit often, to avoid leaking hugepages memory. As such, > I think it is valuable to include in stable. > > Acked-by: Harry van Haaren Applied, thanks