From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 25E7542C5A; Thu, 8 Jun 2023 09:23:04 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9996840A84; Thu, 8 Jun 2023 09:23:03 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 0905440042 for ; Thu, 8 Jun 2023 09:23:01 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 693415C01E5; Thu, 8 Jun 2023 03:22:59 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 08 Jun 2023 03:22:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1686208979; x=1686295379; bh=LHRQL/ifuh8V0ivkPstPQE/YsTv1V60XnBj gs+/DTyM=; b=TABa4+xw3fJ12mUEYHkH+CYs+aH12GSZ4js1VQYdrGsOkFzRjqY vYGB/BlxPWLS9GRrV5gs68yrrmL43pXETuZlWTflrjKLNdeiqOQAbKux0IWyo+rP wuGYzZHlodaM19M56mdg/bDTfD+oPyiOhxewbcvSoKyxkPS++/B4HFz+IIl19t6o kMNpsMa762ky/5MDIHNu+2mDmZrAFJf80zcfohsz6IXUZuijfU3hkb+8pE5X2Hni OHoZDbupc4lii3nasi8MaG4ePMOYD/N7x800DuiqruGvFFhDnWnPKF9zdrlklOdb dUgrSeo3T6AYMxc4pETAXafyZg0SVkRDymQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1686208979; x=1686295379; bh=LHRQL/ifuh8V0ivkPstPQE/YsTv1V60XnBj gs+/DTyM=; b=Ox3hKATT8gMOp9aihEIM0YLZZ1xHQfZho9hcAm3EAR27Zl8v3Cj VcQBUG80hPPZfKC/JEj49LRyd0sdVx0GXp7plLV2+0RaqlI6E4q4TYF/AtYPb7o+ sPaiC44wXetqz9SDONqGbJBE7lOMfuQ5yZuKzR0HjJMyNjysurvE7jDdv0OO8EPg /zwEh6m2qShpztFAu7Okb2LgQyE6G1D/xvl+9a9DRoyOcdl4bbqiF62wEHhz9o6q g4pVco4BQ38HcqyHPFSKLckapuxsxhbLVti0+MxTB4+4CN8JXtI48/RprprXz4y6 CwW1LYD+xNDj2CPhnk4JONtq48bNHoJ2Wbg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgedthedguddukecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnhepgedttdeljeejgeffkeekkedtjeevtdehvedtkeeivdeuuedv ieduvdelveejueejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 8 Jun 2023 03:22:57 -0400 (EDT) From: Thomas Monjalon To: Abdullah Sevincer , Jerin Jacob Cc: Gaetan Rivet , David Marchand , dev@dpdk.org, jerinj@marvell.com, mike.ximing.chen@intel.com Subject: Re: [PATCH v1] event/dlb2: add support for disabling PASID Date: Thu, 08 Jun 2023 09:22:55 +0200 Message-ID: <1977068.NnIJQXNAa5@thomas> In-Reply-To: References: <20230607210050.107944-1-abdullah.sevincer@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 08/06/2023 07:38, Jerin Jacob: > On Thu, Jun 8, 2023 at 2:31=E2=80=AFAM Abdullah Sevincer > wrote: > > > > vfio-pci driver in Linux kernel 6.2 enables PASID by default. > > In DLB hardware, enabling PASID puts DLB in SIOV mode. This > > breaks DLB PF-PMD mode. For DLB PF-PMD mode to function properly > > PASID needs to be disabled for kernel 6.2. > > > > In this commit this issue is addressed and PASID is disabled > > by writing a zero to PASID control register. > > > > Signed-off-by: Abdullah Sevincer >=20 > > + /* The current Linux kernel vfio driver does not expose PASID c= apability to > > + * users. It also enables PASID by default, which breaks DLB PF= PMD. We have > > + * to use the hardcoded offset for now to disable PASID. > > + */ > > + pasid_cap_offset =3D DLB2_PCI_PASID_CAP_OFFSET; > > + > > + off =3D pasid_cap_offset + DLB2_PCI_PASID_CTRL; >=20 > +++ additional folks. >=20 > Is make sense to move this helper function to PCI common for disabling > PASID for a PCI device so that other driver can use if needed > as the implementation is not specific to DLB2. I guess yes it makes sense.