* [dpdk-dev] [PATCH] mempool/octeontx: use smp instead of io barrier
@ 2018-01-04 11:39 Pavan Nikhilesh
2018-01-08 4:05 ` santosh
2018-01-08 4:40 ` [dpdk-dev] [PATCH v2] mempool/octeontx: fix improper memory barrier Pavan Nikhilesh
0 siblings, 2 replies; 4+ messages in thread
From: Pavan Nikhilesh @ 2018-01-04 11:39 UTC (permalink / raw)
To: jerin.jacob, santosh.shukla, dev; +Cc: Pavan Nikhilesh
Use smp barrier instead of IO barrier when sending mbox request as the
write has to be reflected between cores not IO devices.
Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
---
drivers/mempool/octeontx/octeontx_mbox.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mempool/octeontx/octeontx_mbox.c b/drivers/mempool/octeontx/octeontx_mbox.c
index 9525da1aa..6c6900389 100644
--- a/drivers/mempool/octeontx/octeontx_mbox.c
+++ b/drivers/mempool/octeontx/octeontx_mbox.c
@@ -128,7 +128,7 @@ mbox_send_request(struct mbox *m, struct octeontx_mbox_hdr *hdr,
/* Write the msg header */
rte_write64(new_hdr.u64, ram_mbox_hdr);
- rte_io_wmb();
+ rte_smp_wmb();
/* Notify PF about the new msg - write to MBOX reg generates PF IRQ */
rte_write64(0, m->reg);
}
--
2.15.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] mempool/octeontx: use smp instead of io barrier
2018-01-04 11:39 [dpdk-dev] [PATCH] mempool/octeontx: use smp instead of io barrier Pavan Nikhilesh
@ 2018-01-08 4:05 ` santosh
2018-01-08 4:40 ` [dpdk-dev] [PATCH v2] mempool/octeontx: fix improper memory barrier Pavan Nikhilesh
1 sibling, 0 replies; 4+ messages in thread
From: santosh @ 2018-01-08 4:05 UTC (permalink / raw)
To: Pavan Nikhilesh, jerin.jacob, dev
On Thursday 04 January 2018 05:09 PM, Pavan Nikhilesh wrote:
> Use smp barrier instead of IO barrier when sending mbox request as the
> write has to be reflected between cores not IO devices.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> ---
Acked-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [dpdk-dev] [PATCH v2] mempool/octeontx: fix improper memory barrier
2018-01-04 11:39 [dpdk-dev] [PATCH] mempool/octeontx: use smp instead of io barrier Pavan Nikhilesh
2018-01-08 4:05 ` santosh
@ 2018-01-08 4:40 ` Pavan Nikhilesh
2018-01-12 17:25 ` Thomas Monjalon
1 sibling, 1 reply; 4+ messages in thread
From: Pavan Nikhilesh @ 2018-01-08 4:40 UTC (permalink / raw)
To: jerin.jacob, santosh.shukla, dev; +Cc: Pavan Nikhilesh, stable
Use smp barrier instead of IO barrier when sending mbox request as the
write has to be reflected between cores not IO devices.
Fixes: 6da9d24574db ("event/octeontx: add mailbox support")
Cc: stable@dpdk.org
Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Acked-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
---
drivers/mempool/octeontx/octeontx_mbox.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mempool/octeontx/octeontx_mbox.c b/drivers/mempool/octeontx/octeontx_mbox.c
index 9525da1aa..6c6900389 100644
--- a/drivers/mempool/octeontx/octeontx_mbox.c
+++ b/drivers/mempool/octeontx/octeontx_mbox.c
@@ -128,7 +128,7 @@ mbox_send_request(struct mbox *m, struct octeontx_mbox_hdr *hdr,
/* Write the msg header */
rte_write64(new_hdr.u64, ram_mbox_hdr);
- rte_io_wmb();
+ rte_smp_wmb();
/* Notify PF about the new msg - write to MBOX reg generates PF IRQ */
rte_write64(0, m->reg);
}
--
2.14.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH v2] mempool/octeontx: fix improper memory barrier
2018-01-08 4:40 ` [dpdk-dev] [PATCH v2] mempool/octeontx: fix improper memory barrier Pavan Nikhilesh
@ 2018-01-12 17:25 ` Thomas Monjalon
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2018-01-12 17:25 UTC (permalink / raw)
To: Pavan Nikhilesh; +Cc: dev, jerin.jacob, santosh.shukla, stable
08/01/2018 05:40, Pavan Nikhilesh:
> Use smp barrier instead of IO barrier when sending mbox request as the
> write has to be reflected between cores not IO devices.
>
> Fixes: 6da9d24574db ("event/octeontx: add mailbox support")
> Cc: stable@dpdk.org
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> Acked-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
Applied, thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-01-12 17:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-04 11:39 [dpdk-dev] [PATCH] mempool/octeontx: use smp instead of io barrier Pavan Nikhilesh
2018-01-08 4:05 ` santosh
2018-01-08 4:40 ` [dpdk-dev] [PATCH v2] mempool/octeontx: fix improper memory barrier Pavan Nikhilesh
2018-01-12 17:25 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).