* [dpdk-dev] [PATCH] lpm6: fix assigned value is garbage or undefined
@ 2016-04-27 15:07 Daniel Mrzyglod
2016-05-02 13:10 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Daniel Mrzyglod @ 2016-04-27 15:07 UTC (permalink / raw)
To: bruce.richardson; +Cc: dev, Daniel Mrzyglod
Fix issue reported by clang scan-build
Value of pointer tbl_next was uninitialized. When function lookup_step()
take else branch it may provide garbage into tbl = tbl_next;
Fixes: 5c510e13a9cb ("lpm: add IPv6 support")
Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
---
lib/librte_lpm/rte_lpm6.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/librte_lpm/rte_lpm6.c b/lib/librte_lpm/rte_lpm6.c
index ba4353c..32fdba0 100644
--- a/lib/librte_lpm/rte_lpm6.c
+++ b/lib/librte_lpm/rte_lpm6.c
@@ -601,7 +601,7 @@ int
rte_lpm6_lookup(const struct rte_lpm6 *lpm, uint8_t *ip, uint8_t *next_hop)
{
const struct rte_lpm6_tbl_entry *tbl;
- const struct rte_lpm6_tbl_entry *tbl_next;
+ const struct rte_lpm6_tbl_entry *tbl_next = NULL;
int status;
uint8_t first_byte;
uint32_t tbl24_index;
@@ -636,7 +636,7 @@ rte_lpm6_lookup_bulk_func(const struct rte_lpm6 *lpm,
{
unsigned i;
const struct rte_lpm6_tbl_entry *tbl;
- const struct rte_lpm6_tbl_entry *tbl_next;
+ const struct rte_lpm6_tbl_entry *tbl_next = NULL;
uint32_t tbl24_index;
uint8_t first_byte, next_hop;
int status;
--
2.5.5
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] lpm6: fix assigned value is garbage or undefined
2016-04-27 15:07 [dpdk-dev] [PATCH] lpm6: fix assigned value is garbage or undefined Daniel Mrzyglod
@ 2016-05-02 13:10 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2016-05-02 13:10 UTC (permalink / raw)
To: Daniel Mrzyglod; +Cc: dev, bruce.richardson
2016-04-27 17:07, Daniel Mrzyglod:
> Fix issue reported by clang scan-build
>
> Value of pointer tbl_next was uninitialized. When function lookup_step()
> take else branch it may provide garbage into tbl = tbl_next;
>
> Fixes: 5c510e13a9cb ("lpm: add IPv6 support")
>
> Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-05-02 13:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-27 15:07 [dpdk-dev] [PATCH] lpm6: fix assigned value is garbage or undefined Daniel Mrzyglod
2016-05-02 13:10 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).