From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id D90D8558C for ; Tue, 4 Oct 2016 09:42:19 +0200 (CEST) Received: by mail-wm0-f46.google.com with SMTP id f193so150549078wmg.0 for ; Tue, 04 Oct 2016 00:42:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=XLuOE5xEvHNXFHALeGuun3WVODlpKrs5dU9Caaok428=; b=yc1+LOiar3VHl2oebPrZqiu+tm8lhV2ZAL7j9OpgzuoRhIrdvdIT/qIsHswb+bgcr6 SQfN98Kgs/HXXGw4qsmQoIc7Bx0cYAqgS1f1O5Oyzp3GGmG1zJAdYHUNDGr9MkUBXMh6 g9N3GKCmTyEjwVDsRLrdV6ABHrG8Z4UtGMmrC/nHLyLnFWpN3HErZNGb9R7lsOiN3oj3 tXzf1wkFD02QvRxCfSIhbQQeAGZkEfp4+ny/Vxp2yzPqQihTTBmlYslHBwYS2K6WGTen iX6ShLZRVuqKXDjjs8muI0iDSndbNUfA9KsIEyquJNmxfbM868P8Z3oOyw7tyOjcz5ja O2EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=XLuOE5xEvHNXFHALeGuun3WVODlpKrs5dU9Caaok428=; b=QLnnLfqkvofjs/daITo+AL/R4lWKkupNgrmejY1VNErlVJkggnh8MrR7dXTFyUnzzc Kl+FAXMM/zNdJ4Ld1ZlgGlVibRjY0H83npDarUM1smIAUomDefLH8DL98lSmCoaEVrGG Ze3zDBQqTpTQTz/QqywZgsgYNYu+0aU2FfLx8GXIcwxkiQAA8RECXLgsrOfDAgUT1AQx wfpiaUbdhFAn8ohSockuzPz8TyrXji55h/++X1o3N30St/c+j5Jx3HPzDpyk/edt0xB5 abIMC5RjqTXtA3dRB8YmA+wlS6ImmeE6o7kYmgMmhq7bV80b1cX/md/GIEykhZJ6E5UB QgTA== X-Gm-Message-State: AA6/9RlC/pEOpAVFVUVtqxvzWNSFlu3xwDCEbltbPDvJXNsvKZRqc/Q5iTN8UeosKOG1Rofs X-Received: by 10.194.95.105 with SMTP id dj9mr1989106wjb.20.1475566939508; Tue, 04 Oct 2016 00:42:19 -0700 (PDT) Received: from xps13.localnet (237.204.154.77.rev.sfr.net. [77.154.204.237]) by smtp.gmail.com with ESMTPSA id vx7sm2084373wjc.1.2016.10.04.00.42.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Oct 2016 00:42:18 -0700 (PDT) From: Thomas Monjalon To: Shreyansh Jain Cc: dev@dpdk.org, viktorin@rehivetech.com, David Marchand , hemant.agrawal@nxp.com Date: Tue, 04 Oct 2016 09:42:12 +0200 Message-ID: <1978706.bfODzZLsTC@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <629b0e70-5bd1-d376-4fb9-e7c7a102d79f@nxp.com> References: <1466510566-9240-1-git-send-email-shreyansh.jain@nxp.com> <3582057.BR181DtlIn@xps13> <629b0e70-5bd1-d376-4fb9-e7c7a102d79f@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v11 00/24] Introducing rte_driver/rte_device generalization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Oct 2016 07:42:20 -0000 2016-10-04 12:21, Shreyansh Jain: > Hi Thomas, > > On Monday 03 October 2016 07:58 PM, Thomas Monjalon wrote: > > Applied, thanks everybody for the great (re)work! > > Thanks! > > > > > 2016-09-20 18:11, Shreyansh Jain: > >> Future Work/Pending: > >> =================== > >> - Presently eth_driver, rte_eth_dev are not aligned to the rte_driver/ > >> rte_device model. eth_driver still is a PCI specific entity. This > >> has been highlighted by comments from Ferruh in [9]. > >> - Some variables, like drv_name (as highlighted by Ferruh), are getting > >> duplicated across rte_xxx_driver/device and rte_driver/device. > > Both the above are already part of my todo list. > > > What about those pending work? > > > > I would add more remaining issues: > > - probe/remove naming could be applied to vdev for consistency > > Is that for uniformity reasons? I still feel 'probe/remove' are not > appropriate for a virtual device. init/deinit are more appropriate. As > for PCI, probe/remove are standard parlance and hence suit it better > than init/deinit. PCI probe is "scan + checks + init". The vdev requires "args parsing + checks + init". The device will not be initialized if checks fail, e.g. missing support or name conflict. I think it could fit in "probe" rather than "init". The remove word looks appropriate in both cases. > Nevertheless, uniform naming convention can have its benefits - ease of > code understanding being one. Yes that's the other pro for "probe/remove". > Change is simple once we come to a conclusion. > > > - rte_eal_device_insert must be called in vdev > > Ok. > > > - REGISTER macros should be prefixed with RTE_ > > That would include: > DRIVER_REGISTER_VDEV > DRIVER_REGISTER_PCI_TABLE > DRIVER_REGISTER_PCI > > I will publish a patch soon. This would be fairly straightforward change. > > > - Some functions in EAL does not need eal_ in their prefix: > > rte_eal_pci_ -> rte_pci_ > > rte_eal_dev_ -> rte_dev_ > > rte_eal_vdev_ -> rte_vdev_ > > rte_eal_driver -> rte_drv_ > > rte_eal_vdrv -> rte_vdrv_ > > > > > > It can be merged with changes for: > - drv_name > - EAL_ before _REGISTER_ macros > - eth_driver => rte_driver naming Good. Could you make it this week, please?