From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8ADF0A0487 for ; Thu, 4 Jul 2019 23:25:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7F4F658C4; Thu, 4 Jul 2019 23:25:36 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 50DC74D27; Thu, 4 Jul 2019 23:25:35 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id D1B6F21DFB; Thu, 4 Jul 2019 17:25:34 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 04 Jul 2019 17:25:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=fhVZUS0ijUqQHg3BBGTw2Rh46qXnB94uc+z9eeLVEEE=; b=JzpiPkPJNmDF Q4lXXMifTWpOtx8yfQOC1jWioOC2LAdzfFBpTrPnUEPbTuJaU1AjmNSpbwC0gpW7 I2REFup/kUv5/4ylQ2hQAhFbsWrJBtmHbvj2u+xeQ0F2C6i3iIFvHSnrPs0/LbA9 W4OCmpHxVZUfPq60ayc7z/msjp8ub9U= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=fhVZUS0ijUqQHg3BBGTw2Rh46qXnB94uc+z9eeLVE EE=; b=gppcqyuiOx3wDh8nNUtV6/ZKl9bkfYtdvFY/KPktsR+431GpVRmZh57Cp S/yjRv1JBiIZYANVU/fAEgTCwKDgN0QSsNbhpJWWF/QCzz1W4VGSF4BgKS0uBBgI gbXGYUL9sqxUVpipconJ7eVN4RKRgiJX9gvVvj8Bd6v62sfJhKml5RADBwI3z3wD ZAzeLRZw4CY1nwq4MDAGxSnl8IvE/f8p19ZYNaP7IGf+GtKouEWgTmc0rsf7U1Oa WF3kAtQS9ojBLmm9krY5FAS5OsCnhziX1zANt5S58b5Q2Md64NsBFA6W6S4zc+FQ WnbbDFBByZYemLl+DKDWxP5jjNx8w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrfedvgdduieefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 97E01380076; Thu, 4 Jul 2019 17:25:33 -0400 (EDT) From: Thomas Monjalon To: "Parthasarathy, JananeeX M" Cc: stable@dpdk.org, "Dumitrescu, Cristian" , David Marchand , dev , "Pattan, Reshma" , "Singh, Jasvinder" Date: Thu, 04 Jul 2019 23:25:32 +0200 Message-ID: <1979037.n3m16vrDg2@xps> In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D891268E8B9040@IRSMSX108.ger.corp.intel.com> References: <1562066494-25411-1-git-send-email-jananeex.m.parthasarathy@intel.com> <3EB4FA525960D640B5BDFFD6A3D891268E8B9040@IRSMSX108.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] lib/table: fix table autotest ut crashes in ipv6 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 02/07/2019 13:50, Dumitrescu, Cristian: > From: David Marchand [mailto:david.marchand@redhat.com] > On Tue, Jul 2, 2019 at 1:22 PM Jananee Parthasarathy > wrote: > Unit test table_autotest results in segmentation fault. > Crash occurs in test_table_lpm_ipv6_combined(). > > Variable 'nht_pos0' used as array subscript is not initialized > in rte_table_lpm_ipv6_entry_add(). It will not be assigned, > if a rule does not exist. > > In such case a junk number or invalid array index might result in > segmentation fault due to array out of bounds when > lpm->nht_users is used with such invalid array index. > > Fix is to initialize the variables used for array subscript. > > Bugzilla ID: 285 > > Fixes: d89a5bce1d ("lpm6: extend next hop field") > Cc: stable@dpdk.org > > Signed-off-by: Jananee Parthasarathy > [...] > It fixes the segfault I saw, leaving the ack to the maintainer. > Tested-by: David Marchand > > > Acked-by: Cristian Dumitrescu Applied, thanks