From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CA97BA04FD; Mon, 23 May 2022 20:00:59 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 83DB04067B; Mon, 23 May 2022 20:00:59 +0200 (CEST) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by mails.dpdk.org (Postfix) with ESMTP id 16A9E40156 for ; Mon, 23 May 2022 20:00:59 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 3522832009BC; Mon, 23 May 2022 14:00:56 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Mon, 23 May 2022 14:00:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1653328855; x= 1653415255; bh=m3kCmV3aB5NUIADpp+r6ShyAjdnLp7G8+M0/0kqnZ2U=; b=M A2MNkxRF1/pGP5oNMm52YT8vClkxVCjIj8OegEnlNwPuR9sEkGFJpwZAyFIEiggm 3zaWkCkI3IUwfmhRQovgrISA+D6rMQAS7gbFdRUjYlS+v7ifJwTLtKfGhltF6vuO QJKirfh+7BZwAIyTyQLcxqvnWEbY6QKV/nUded6Ilys+RShxOUyXX8L3K/0szEaJ qC/7jHpU62Ar0AiuqC9XIjJ/9K8IlNXPg/c0wN2bpVqfhAg+A2PTmp3z+j3PTSEm zfYqGkhWnxC/SyVQOprnQdzKQXYEBA0Wbw8RWJ5jIZP+LFuLCdUh81pOzJ65I98X Pprl8V5wP1egfz16wJxiQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1653328855; x= 1653415255; bh=m3kCmV3aB5NUIADpp+r6ShyAjdnLp7G8+M0/0kqnZ2U=; b=F BK4kY0/nn4YDN0A2uMV9+CmgkUccnVKKaRAcTG7TNWIcfc/fzHuf6CGwU0opgdMD RjbNh0iEhZ0Mzp0947lsFBJIrv3ENOp67kTAVtqN0TjV3CkDkWtY1NhIWZaJL17+ sKDRHP6P9zV/9nIvGaUzETcW4bwVFq2XaROEvxN09Hi4Yf8PYtVz8Uq3ywT7tbpy ikmAt3ufH3Ivdn5P8lGk1LxmqQ53SG2EaTXUd9ufgO1ShBYRoC5p368fPT/jZDa4 Od5fBrKHyEi/Z6LhdkcFGiooRMc70v3+ex8vV8VoiblH61KG0nfNHGqviUK96TNX 2os7A0+qn3uYZVtf86IwQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrjedugdekkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddtieek gfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 23 May 2022 14:00:53 -0400 (EDT) From: Thomas Monjalon To: Subendu Santra Cc: Reshma Pattan , Stephen Hemminger , Hemant Agrawal , dev@dpdk.org Subject: Re: [PATCH] app/procinfo: show all non-owned ports Date: Mon, 23 May 2022 20:00:45 +0200 Message-ID: <1979063.0S5aU1g85B@thomas> In-Reply-To: References: <20220510132118.22688-1-subendu@arista.com> <23962511.kmuVQn2iE0@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 23/05/2022 18:10, Subendu Santra: > Sure. Will add a sentence about the issue which is getting fixed. > However, I have already added Fixes: 1dd6cffb6571 in the patch. Sorry I missed it. > Is there anything else that needs to be done apart from this w.r.to > "Fixes:" comment? No that's fine, thanks. > > Regards, > Subendu. > > > On Mon, May 23, 2022 at 8:12 PM Thomas Monjalon wrote: > > > > 23/05/2022 12:53, Subendu Santra: > > > Hi Reshma, Thomas, > > > > > > What do you think about this patch? > > > > It looks to be a fix, right? > > Please add a sentence about the previous behaviour, > > explaining what is fixed. > > > > Ideally you should show the commit doing the mistake > > with the syntax "Fixes:" as in other commits of this tree. > > > > Thanks > > > > > > > On Tue, May 10, 2022 at 6:52 PM Subendu Santra wrote: > > > > > > > > Show all non-owned ports when no port mask is specified > > > > > > > > Fixes: 1dd6cffb6571 ("app/procinfo: provide way to request info on owned > > > > ports") > > > > Cc: stephen@networkplumber.org > > > > > > > > Signed-off-by: Subendu Santra > > > > --- > > > > app/proc-info/main.c | 4 ++-- > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/app/proc-info/main.c b/app/proc-info/main.c > > > > index 56070a3317..2be24b584e 100644 > > > > --- a/app/proc-info/main.c > > > > +++ b/app/proc-info/main.c > > > > @@ -1504,10 +1504,10 @@ main(int argc, char **argv) > > > > if (nb_ports == 0) > > > > rte_exit(EXIT_FAILURE, "No Ethernet ports - bye\n"); > > > > > > > > - /* If no port mask was specified, then show non-owned ports */ > > > > + /* If no port mask was specified, then show all non-owned ports */ > > > > if (enabled_port_mask == 0) { > > > > RTE_ETH_FOREACH_DEV(i) > > > > - enabled_port_mask = 1ul << i; > > > > + enabled_port_mask |= (1ul << i); > > > > } > > > > > > > > for (i = 0; i < RTE_MAX_ETHPORTS; i++) { > > > > -- > > > > 2.28.0 > > > > > > > > > > > > > > > > > >