From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D4DD2A0C47; Tue, 26 Oct 2021 10:44:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C2C7C426D8; Tue, 26 Oct 2021 10:44:46 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id A01CA41C25 for <dev@dpdk.org>; Tue, 26 Oct 2021 10:44:45 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 526C75C02F7; Tue, 26 Oct 2021 04:44:45 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 26 Oct 2021 04:44:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= iq03e55gtUUKWRpA7tFqIPygCJqqOGvxvQXKU0udNrw=; b=VPvayrY9baq8jwYj XPInKhjE8QrK/shY2YrllpQwD1gEghy0UIwQASCJtUb87z0gl6kuuRPPw3ZiZmym MLRgVHaL0h4cjxG9vfACy+b33fIeSytaha7WXq51aA1LZAZzpLwCyGwRSjfujfNS vOipiMij10JdB4EdT60+tW3DdPOaGzIZbhV4YHVNJv0m5/LpjLpKbvV0DMkusvOk AE5EN2uyoWzqY1YrLamlVGsZfUAcCp8LH3A3LcB7kpViYmXrruU/njtJutwkz6bU hEMbO5Qaj88J38KX/XUXZvMF8un3RcGzUCiCRm7O/SH1SCS3+/OXh8m+TSDFfdCm KYRmng== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=iq03e55gtUUKWRpA7tFqIPygCJqqOGvxvQXKU0udN rw=; b=M3ebM2i9JU/Nd6sovhfwrTTKkskmN71iaWEe5CJQmUYfAaj2Pf7q0z9IO GHF4kKyQWy4eDGN2H7nObxIA4zmzbTmZew5BgXi9hv84GcKAAhIm13452a5S3MEC n65tvtBFTw/PojnHC3inGWmnQ7prxW9CXa9Pc/FlviOxdDkGlpqZNAkBQPs1bqTT jBt5z71XCiHz+tDCeYbK7X0bcnXF44jFnQaooDW+PJ20kYFoKX8ss3egB4YQBCWI MpnZ5nqe+rtgYRPBd6PU0DMZffsLuFqQanTgdCwOxR3GalDpPOck45ciAeHZ4VeZ L6z9+d/TguWk86fJOlyAIaOpWP9eA== X-ME-Sender: <xms:_L93YYG_qgtDcsMSzzcYsPC8J2iesqv-Diqj_mHvrXS0bM2OLuV0YQ> <xme:_L93YRWMoxAsWyWVA9dvHaoWrE3RJsqdcmnEY_xdR_1GrZ1eiNVKgv9Myl2VS9Qih 11aSYiWJYMhAXriIg> X-ME-Received: <xmr:_L93YSLbOVbdAaPZj03lpAbcEI5942ps4lHzbDhZ0FO8hJxo4bNa7iNMii_snQK10twoffjEJ6ffdlx5kX3xrPY35w> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvdefjedgtdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: <xmx:_L93YaFFvnVo9YJG-TosNDKJMKbwCZdXTZD126FGinQovTP2O1xXTw> <xmx:_L93YeUPQh9-srbi5UIG7mGe0ggCaKXt46tXwTVP9ahRBtUizVkqUg> <xmx:_L93YdMea2c8f0Zf0SBNevyyH08oeLqNE0UTDbhSwHLZ__6MBy9j6w> <xmx:_b93YZFFjMzUUHSb6sjUQA9VYUnxXHC2J598O4AMdjNqJPSY53cyxw> Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 26 Oct 2021 04:44:43 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Jie Zhou <jizh@linux.microsoft.com> Cc: dev@dpdk.org, dmitry.kozliuk@gmail.com, roretzla@microsoft.com, navasile@linux.microsoft.com, dmitrym@microsoft.com, pallavi.kadam@intel.com, talshn@nvidia.com, aconole@redhat.com Date: Tue, 26 Oct 2021 10:44:42 +0200 Message-ID: <1979394.QiuXEhXhK7@thomas> In-Reply-To: <20211026004744.GA5912@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1634187170-3986-1-git-send-email-jizh@linux.microsoft.com> <1800954.qoURpX2mz1@thomas> <20211026004744.GA5912@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v6 01/12] lib: build libraries that some tests depend on X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 26/10/2021 02:47, Jie Zhou: > On Mon, Oct 25, 2021 at 05:38:42PM +0200, Thomas Monjalon wrote: > > 14/10/2021 18:21, Jie Zhou: > > > Enable building subset of libraries that tests depend on for Windows > > > > > > Signed-off-by: Jie Zhou <jizh@linux.microsoft.com> > > > --- > > > lib/meson.build | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/lib/meson.build b/lib/meson.build > > > index b2ba7258d8..bd6c27deef 100644 > > > --- a/lib/meson.build > > > +++ b/lib/meson.build > > > @@ -82,9 +82,11 @@ if is_windows > > > 'bitratestats', > > > 'cryptodev', > > > 'cfgfile', > > > + 'efd', > > > 'gro', > > > 'gso', > > > 'latencystats', > > > + 'lpm', > > > 'pdump', > > > 'stack', > > > 'security', > > > > > > > It needs to be rebased after the recent changes to disable libs on Windows. > > But instead of such patch, I would prefer one patch per lib, > > with Tested-by tags showing that the lib is tested and working on Windows. > > Also you need to Cc the maintainer of the lib being enabled. > > > Thanks Thomas. Will rebase in V7, and will separately enabling efd, lpm, and their corresponding unit tests in two patches after this one. I think it enabling can be done in separate patches out of the series. There is a chance to merge such patch before the big series.