From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E035E432BA; Mon, 6 Nov 2023 16:38:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B008C406BC; Mon, 6 Nov 2023 16:38:17 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 7F056402C2 for ; Mon, 6 Nov 2023 16:38:16 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 1D1DB5C0230; Mon, 6 Nov 2023 10:38:16 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Mon, 06 Nov 2023 10:38:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1699285096; x=1699371496; bh=Z6ZR4YIovgQf3S+P0Tl5llHwOGlX80vQU6B 9WzVcasQ=; b=mhnZM1t42eG5rgRACMQiXIb8YhKF+AdVRSZXfURGZf5RxI4gy49 KTnM2+wOKN9B/UI1QpCj1m1ZUnmI1fcSi+3Gr2IUNs8Mj1vkIXHnQagonwoFg50t adaKK6v/mqW+MRHlaaWlitXejgqZiR34k6597PlOgIJoW+diyqi3kRr+aaDP6XiO hBWVfm6xXuWQDz/diJTElINJH+Yi4Sb+Vu13qXnv3rmFVMIkwoiQirBvnH6ydMOX GN95S1X+WsYPKNcr+jwFpwWEBzmHk5393gr+v8sza7POzJcBQacUbEBlqQYlVXgs Lb6s8bpknBHXrnv5d9APwss/AVWbnKGEoXQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1699285096; x=1699371496; bh=Z6ZR4YIovgQf3S+P0Tl5llHwOGlX80vQU6B 9WzVcasQ=; b=gAjwwFCgU8L/hkU7ivAeEsBAjoDh+UC1Mqiq1SOXXQ2yDcvdIf+ y/2fqDcRl8ThjcCiaeEsBsWTUV4O/JVsnxKqB9NRoWBjoIGni5FDxjh83GB6THW7 Q3tMeDQFmPvBxOEYO3kr2zJ/FrVrIrxRejzbNtRf1/4SdXUxb/0LPZorTB0O+sph FWbB1GhvXlUppz10oP24aJl6p1ep4SlDLOFjZqO5BSHaiVf5GovzQOk3yzlDN4ue WNd8TR+nTWQd1H9YCVtuqVKZ0h9+TIikjncYR72RGmVXnrvNxiK36b7d4Y18JNIF AyP0azd4T+Y+dXmLWEYeaKl4BTGg2xnZKIQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedruddugedgjeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 6 Nov 2023 10:38:14 -0500 (EST) From: Thomas Monjalon To: Ruifeng Wang Cc: dev@dpdk.org, Bruce Richardson , nd , Paul Szczepanek , Joyce Kong Subject: Re: [PATCH v1] config/arm: correct cpu arch for cross build Date: Mon, 06 Nov 2023 16:38:13 +0100 Message-ID: <1979791.8hb0ThOEGa@thomas> In-Reply-To: References: <20230822074743.3243015-1-joyce.kong@arm.com> <4497027.8F6SAcFxjW@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 06/11/2023 15:31, Joyce Kong: > > -----Original Message----- > > From: Thomas Monjalon > > Sent: Monday, November 6, 2023 10:10 PM > > To: Ruifeng Wang ; Joyce Kong > > > > Cc: dev@dpdk.org; Bruce Richardson ; > > dev@dpdk.org; nd ; Paul Szczepanek > > > > Subject: Re: [PATCH v1] config/arm: correct cpu arch for cross build > > > > 18/10/2023 07:40, Joyce Kong: > > > > From: Thomas Monjalon > > > > 22/08/2023 09:47, Joyce Kong: > > > > > The cn10k cross build file sets cpu to 'armv8.6-a' while > > > > > N2 is armv8.5-a arch. > > > > > The cpu field in the cross file doesn't take effect as > > > > > config/arm/meson.build controls machine_args for march. > > > > > Then correct the value in arm cross files to 'auto'. > > > > > > > > I don't get it. > > > > Why setting a value if it has no impact? > > > > Looks like something is overcomplicated. > > > > > > > We still have to declare them here because meson would check the 'cpu' > > line in the config file, otherwise it would report missing {'cpu'}. > > > > OK > > > > Then why not all cross files are set to auto? > > > Actually, I set all the Arm cross files to auto in this patch. Maybe I have to figure it out in the commit line? What about these ones? git grep 'cpu = ' config/arm | grep -v auto config/arm/arm64_altra_linux_gcc:cpu = 'armv8.2-a' config/arm/arm64_ampereone_linux_gcc:cpu = 'armv8.6-a' config/arm/arm64_bluefield3_linux_gcc:cpu = 'armv8.4-a' config/arm/arm64_cdx_linux_gcc:cpu = 'armv8-a' config/arm/arm64_hip10_linux_gcc:cpu = 'armv8-a'