From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CAD6E429AA; Fri, 21 Apr 2023 10:28:36 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5F53B410F3; Fri, 21 Apr 2023 10:28:36 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 0D59F410DD for ; Fri, 21 Apr 2023 10:28:35 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id A12EC5C015B; Fri, 21 Apr 2023 04:28:34 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Fri, 21 Apr 2023 04:28:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1682065714; x=1682152114; bh=Sycti7gcQKz+N6J81o7B55CeImjNZn4pvl2 RiA8fpPE=; b=DVbkoos6vK/+mWQMsDD/oXk5/DrwD+hDqfb4CqCBk2MLRP3dDda SXN0VqC1LDjumX03i/Zqp5sKQssGCDr42h5VhbePzfczpE+xYtGtyX6Pz+sXg6DT 41mUTVkeCGRaxcn4eW7VdVVcMaPqoEAhdIErYgdYderroGTt7QeV5w7IPUEIe2kq FYxWJclzrxEGBoL4cUmJET90gjK9ywrbJqTGVH5675uFrwfmb9TqIKtNfjODllgU snIAKsDHv1VSdOLKZhQh7W3bOhphH0dhffwRGYQbkxPadrPXZRD1jXNTQ7g7t/A9 nZdPEycWHHKHB8zYgvRJnSYTJXhYR5NCJfw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1682065714; x=1682152114; bh=Sycti7gcQKz+N6J81o7B55CeImjNZn4pvl2 RiA8fpPE=; b=Iop5ni+f6kBve+c6X7QLHOHQtqmZ3HL2RtSrTK0PsQ2llNguv3y Kzgd3oC4TkIB8uWlmvJFXzYo9IdrpiD/l1dQZiB6+JaKiAtWJ5O7NhVO2ZUoDaVI Cpa2ruUZT8UY3P4nfBQ6a007VaxKJkV/7A1DQoe5R+5MCJMPUo9+ASh3HnOca8Ud UHa45S0ZhEWRe3hcfvahq5vVgvn68SEWRt7vdLo9ry0DNZmMp8c7ypo+dQkvw31c JRBsSUF+eRqPMSduBWrXst7mvAvhy5kH2xFOwkQM4ov5gqSjLJ2cNXBJ8xQxF47e 6JMlPDRyVCtUhaCdQRSQLWwszIInSdyI++w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfedtgedgtdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeefffeikedtuddufedulefhtefgtdevueehudetudejffelhedu veegveetffeiffenucffohhmrghinhepohhpvghnqdhmphhirdhorhhgpdguphgukhdroh hrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpeht hhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 21 Apr 2023 04:28:33 -0400 (EDT) From: Thomas Monjalon To: Stephen Hemminger , "Lu, Wenzhuo" Cc: "dev@dpdk.org" , Brice Goglin , david.marchand@redhat.com Subject: Re: [PATCH] usertools: enhance CPU layout Date: Fri, 21 Apr 2023 10:28:31 +0200 Message-ID: <1980504.PIDvDuAF1L@thomas> In-Reply-To: References: <1681795541-68384-1-git-send-email-wenzhuo.lu@intel.com> <20230418094646.799b2fc3@hermes.local> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 21/04/2023 03:47, Lu, Wenzhuo: > Hi Stephen, > > From: Stephen Hemminger > > On Tue, 18 Apr 2023 13:25:41 +0800 > > Wenzhuo Lu wrote: > > > > > The cores in a single CPU may be not all the same. > > > The user tool is updated to show the > > > difference of the cores. > > > > > > This patch addes below informantion, > > > 1, Group the cores based on the die. > > > 2, A core is either a performance core or an > > > efficency core. > > > A performance core is shown as 'Core-P'. > > > An efficency core is shown as 'Core-E'. > > > 3, All the E-cores which share the same L2-cache > > > are grouped to one module. > > > > > > The known limitation. > > > 1, To tell a core is P-core or E-core is based on if > > > this core shares L2 cache with others. > > > > > > Signed-off-by: Wenzhuo Lu > > > > Side note: > > This tool only exists because of lack of simple tool at the time. > > Looking around, found that there is a tool 'lstopo' under the hwloc package > > that gives output in many formats including graphical and seems to do a better > > job than the DPDK python script. lstopo existed already when introducing this python script. See its home page: https://www.open-mpi.org/projects/hwloc/ We talked about dropping the DPDK script in the past: http://inbox.dpdk.org/dev/20151127161008.GA27472@bricha3-MOBL3/ I recommend using "lstopo-no-graphics --merge" > > Not sure how much farther DPDK should go in this area? > > Really should be a distro tool. > > Many thanks for your review and comments. > Have to say I'm a green hand in this field. Just imitate the existing code to write mine. So, still trying to understand and handle the comments :) > > Better to understand more about our opinion of this script before send a v2 patch. > I've used 'lstopo'. It's a great tool. > To my opinion, considering there're Linux tools to show all kinds of information, the reason that DPDK has its own tool is to summarize and emphasize the information that is important to DPDK. Here it's that some cores are more powerful than others. When the users use a testpmd-like APP, they can choose the appropriate cores after DPDK reminds them about the difference between cores. > Add Thomas for more suggestions. Thanks. Adding Brice, hwloc maintainer. I think it would be better to contribute to the hwloc project. If we need a different set of info, we can probably tune it with options.