From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A2172A0567; Tue, 9 Mar 2021 10:57:26 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 62E8D22A493; Tue, 9 Mar 2021 10:57:26 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id 1150122A443 for ; Tue, 9 Mar 2021 10:57:25 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id A86775C00DC; Tue, 9 Mar 2021 04:57:24 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Tue, 09 Mar 2021 04:57:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= BCXjVd+h99tNXvJqh9AtPG/1qDrrhFp+bjSEwHSM0P4=; b=ERl27TZZqRrJFZKp FyyNeb6516VwOClvB5rk2RF7RFjmZgOYJsFNr/Z7bonxQi1DriuCvrpFpWJb7gsu arFY3NKqEOkEHdUKGB0ikEtaDCzDqJIUp5F1yjCO6bRCypkuVnqPbsI49mZv3mOn riDQEHDJ7F5nl/D0y+vwSEcKLTVGXmENv++juSJlprGJMHWImUQeVoKKV53j3N73 5glBXw+36CwZEdM1QVQWARWwzBKVGrLfN9MPJrSljmF+f3mhz6P2gLPBO7tlGoU0 HRCbJh0fAyPqmZx6M603Y+IgDfki6lb5HgJLfK62K2kAtMjEulsOy9JuQIlx0tk9 MTu+2Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=BCXjVd+h99tNXvJqh9AtPG/1qDrrhFp+bjSEwHSM0 P4=; b=QIbX9eBIxSotVaMGLK86JsdtGry1MY1+7CkmrxVZ/hcqZCAzMCECVfPGd TvTLXa0Q9vpyide4iHca9iMYhC9aFkQH2HgG7mXf4hEGL9Z0kOq0AmWHXW6KHj6E MCD9rLMKs/CmwWhGQ2MM/pB1zrvvLpbPBbNX9HMgKeXCjFTdcQxPqe3QWOvTwKI0 CRw15lL773COAsnvPddgiaMOqihyW55ryLsWJoiH3ekY75JRSQiKAj9EYedfhLj3 RajM2MVlVxsN7yb/mryDXbBXFNKUfyTmon8Sbt/fSCq1Pr4l4FckA8o+pv10yjKe rG6DNS6O1ovQshNKn+rmC5wVdyDXw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudduiedgtdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 0E6041080064; Tue, 9 Mar 2021 04:57:21 -0500 (EST) From: Thomas Monjalon To: oulijun , Ferruh Yigit Cc: xiaoyun.li@intel.com, dev@dpdk.org, linuxarm@openeuler.org, Andrew Rybchenko , Aaron Conole , Honnappa Nagarahalli Date: Tue, 09 Mar 2021 10:57:20 +0100 Message-ID: <1980606.NPtmdolmL5@thomas> In-Reply-To: <35583d9b-0782-74a7-95df-aef1ca35f819@intel.com> References: <1614929583-37727-1-git-send-email-oulijun@huawei.com> <35583d9b-0782-74a7-95df-aef1ca35f819@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH V2] app/testpmd: support Tx mbuf free on demand cmd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 09/03/2021 10:53, Ferruh Yigit: > On 3/9/2021 8:49 AM, oulijun wrote: > > 2021/3/9 1:33, Ferruh Yigit: > >> Similar to above comment 'rte_eth_devices' is the internal variable, > >> applications should not access it directly. > >> > > No API is available, and multiple references exist in the testpmd file. > > Technically 'rte_eth_devices' is still visible to the applications because of > the static inline functions, in theory it should be hidden. > > But this variable accessed by our test application multiple times may be the > sign that something more is missing. > > Thomas, Andrew, what to you think to try to clean this usage from testpmd and > add more APIs if needed for this? I fully agree. The test applications and examples should help identifying gaps in the libraries. So we should not workaround the official API.