From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 82A0BA04E7;
Thu, 5 Nov 2020 19:18:53 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id CA87C100C;
Thu, 5 Nov 2020 19:18:51 +0100 (CET)
Received: from wnew1-smtp.messagingengine.com (wnew1-smtp.messagingengine.com
[64.147.123.26]) by dpdk.org (Postfix) with ESMTP id B4BE9F90;
Thu, 5 Nov 2020 19:18:49 +0100 (CET)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.42])
by mailnew.west.internal (Postfix) with ESMTP id C52ACB1C;
Thu, 5 Nov 2020 13:18:46 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
by compute2.internal (MEProxy); Thu, 05 Nov 2020 13:18:47 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=fm2; bh=
VkXrEMsfUk2ypmBNrmXgkXLIw1DJpA07ayoMx+K16Ag=; b=kr44mfltS3JfwesC
ZluyOIkZm0d431w05MUv+vm9GVOvEEOtw5QE/hYtg802g4Zc8A9JxoElbZYFxYLe
YXg/6pJQtDfqseafnKO9HtysYs4s0RRTlcnRn7xXxJoGSRz3/OcfpqQu2QNdK9nm
4j9codKMHxmBW8zE6PA+P0QJzWSyJWZc5woT8WI9rIYe7HTE4d0b+cDSlIt3VsKd
FX+We6GFCWxhVWSv8xtNRsaFFC4w8T6/5JwEOd3rTY+vFmELhSSm4PQKV+d72dgv
pEXN+XZtdoA6JAiGaH8NpvEEKN3eYgXK0Z1wf6w13Z+o/RXXCjNiydzFoTBTQEie
HmRjoA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm1; bh=VkXrEMsfUk2ypmBNrmXgkXLIw1DJpA07ayoMx+K16
Ag=; b=KuPLiiI+WnXn3oKL9ctFml5BNM0b0TQyWpJ6Iyy1gV0LGJUISqx7WarTB
aJK4iVCeX2pY0TE92nd7ArTUDfqd7rD+BHhToP1lKnwdRBG8JPo452KkoGbVT/Qp
A4guYc+7M79oWQcykq5LFoPpyBC4o1+W98PzkjGOENmRTxUuo2/1s+rv4CLxm9OV
eklp+dMHwpRYFsRNTJldRz1il/0b9e7VdU81u6Y5Ny2se9cthUoNzL75ZaJgU+fS
kBAkg0fRoG+55AYq6cPxMfkswCSlryNqeMGUDGq9aYBHZ8wyPznTU6SsXwOXXoxb
I04AZEUgjiZKG5hl1RD0I7iMDdtUA==
X-ME-Sender: <xms:BUKkXyd6aN55Ho5npNlhUX6cCCepCBh6a1kaDwqULaI1B8jtEHaGEg>
<xme:BUKkX8MoJUZ5cNDveg1p-ppI8x5P-W3_au_kV7XantUAGbpbRF42I2uYrwETWwiY6
pUXWktoEF0NG5POTA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedruddtjedgudduudcutefuodetggdotefrod
ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm
rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc
ggtffrrghtthgvrhhnpeffvdffjeeuteelfeeileduudeugfetjeelveefkeejfeeigeeh
teffvdekfeegudenucffohhmrghinhepughpughkrdhorhhgnecukfhppeejjedrudefge
drvddtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhl
fhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght
X-ME-Proxy: <xmx:BUKkXzjlleVaJPF1wUQGH19_Wkhr1u0ogPTin2MYo-eGvEsrkz8FCg>
<xmx:BUKkX_9URpHSWlo_TuAUva_6jfKWnYDmIuxF4YhzPJvdlPv84NNvew>
<xmx:BUKkX-sOp8ScjNQD7E6vbAnAd09dqkAw2A4vz4jJBXnzW3DqWckTSw>
<xmx:BkKkX4KzJrArE5BFEqPLEo3Y6XM8I1H_w1b-zlDahHIq0vNFFT-vpyPr88E>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id 3077B3060057;
Thu, 5 Nov 2020 13:18:44 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, david.marchand@redhat.com, olivier.matz@6wind.com,
andrew.rybchenko@oktetlabs.ru, lance.richardson@broadcom.com,
maxime.coquelin@redhat.com, stable@dpdk.org, Wenzhuo Lu <wenzhuo.lu@intel.com>,
Beilei Xing <beilei.xing@intel.com>,
Bernard Iremonger <bernard.iremonger@intel.com>,
Steve Yang <stevex.yang@intel.com>
Date: Thu, 05 Nov 2020 19:18:42 +0100
Message-ID: <19811014.kdb43H6thT@thomas>
In-Reply-To: <bced796c-1441-93a9-ea17-4400a2424ef1@intel.com>
References: <4da07e46-cf17-57ac-c38d-aa82aacc895e@intel.com>
<20201105174424.4131345-1-thomas@monjalon.net>
<bced796c-1441-93a9-ea17-4400a2424ef1@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH 1/1] app/testpmd: revert max Rx packet length
adjustment
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
05/11/2020 19:11, Ferruh Yigit:
> On 11/5/2020 5:44 PM, Thomas Monjalon wrote:
> > The fix of max_rx_pkt_len for allowing VLAN packets in all cases
> > was breaking configuration of some drivers. Example with virtio:
> >
> > Ethdev port_id=0 max_rx_pkt_len 11229 > max valid value 9728
> > Fail to configure port 0
> >
> > Trying to fix the logic was revealing other issues in some drivers.
> > That's why it is decided to revert.
> >
> > The workaround for the original issue would be
> > to set the MTU explicitly from the application
> > with rte_eth_dev_set_mtu().
> >
>
> Sent this option as RFC:
> https://patches.dpdk.org/patch/83756/
>
> > Fixes: f6870a7ed6b3 ("app/testpmd: fix max Rx packet length for VLAN packet")
> > Cc: stable@dpdk.org
> >
> > Reported-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied