From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f180.google.com (mail-wr0-f180.google.com [209.85.128.180]) by dpdk.org (Postfix) with ESMTP id E51CBCFA0 for ; Tue, 28 Mar 2017 17:22:53 +0200 (CEST) Received: by mail-wr0-f180.google.com with SMTP id l43so108779496wre.1 for ; Tue, 28 Mar 2017 08:22:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=tzAi75uBWgXV1ZeBFJVv5cVRKuY5TeWrNnaL0lRfpx0=; b=Q48CAuxNiEXJ8RrfVpPYGs6KJv1yk1ft3+1ulSmjtdG7qKkdAl0RlhYpCraeGwBxGc tEvHqcCmmbMGwK1NXoDduT0lLhl73cIkeHdKGQfJf9R6E8WrBRYQt0N5s1ZvugbQAUKo 8zrS4YUVMoyGxBJPXyCwO8dxnUo9RoSj+C9Rrru3SOs1014ocOdW/xEp9iZQI93dcO0o pMx5jnZ9kHW6bQUJH0Ec2rUrRlv4kmkzhd70LsXaK2oYR9WoJsfMSegHbISk2adazz4Q Uw7sEbmwFOGj1GYb9ZcSPy4UYHyzMNsQ+dVaTvo+gZ/yqGlKV/jAG+DQ3Dq0T8XmWAZ5 zncw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=tzAi75uBWgXV1ZeBFJVv5cVRKuY5TeWrNnaL0lRfpx0=; b=gxvMc30Ruu0/s5uHJNmXh2t8YCjGSlbpMoPz2TaA9SFD/RuhlRyAo0tvJOioVA2xTx RMZUT+lpgh2SMBZ0HTVvBmdpp5T0dUYPkbNy+/ZIrH6NqFif49XA+ITXWHCrYv6wc/0S JQ5xZ5WHwPpYWt08KmVek3nKy4ancIQkW1pYsjMKS/tMwWPZDSla/MjpS0VTtmjsk4be NjxaIf794ha7udsrh8V9SEJlN9s7iXXfPvRtBWxaJluUEFx4K/4uCJIVN4YwK+dl5f+y 7ODNWvnKBDSUDOAmVqODo1tzBvsHcCmzGZLHPy7iGeXnyQG1NePUjVvYWr9H/+2y/2hu aeQw== X-Gm-Message-State: AFeK/H0z3Dk82/kJgaAyw7hhlHTPWWRr8G8Msq7BtrCDlAo3Szy/cy22Ru4Apy/ZLHX7Nx9H X-Received: by 10.223.139.5 with SMTP id n5mr26206578wra.200.1490714573730; Tue, 28 Mar 2017 08:22:53 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id j26sm5271230wrb.69.2017.03.28.08.22.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 Mar 2017 08:22:53 -0700 (PDT) From: Thomas Monjalon To: "Zhang, Helin" , "Ananyev, Konstantin" Cc: dev@dpdk.org, Olivier Matz , "Dai, Wei" , Guo Fengtian , ferruh.yigit@intel.com Date: Tue, 28 Mar 2017 17:22:52 +0200 Message-ID: <1981763.1ss0qQn5ig@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20170324151148.5c3d9f9d@platinum> References: <1484154254-31387-1-git-send-email-olivier.matz@6wind.com> <20170314104640.32b06adb@platinum> <20170324151148.5c3d9f9d@platinum> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] net/ixgbevf: fix stats update after a PF reset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Mar 2017 15:22:54 -0000 Please ixgbe maintainers, what can be done for this fix? 2017-03-24 15:11, Olivier Matz: > Hi, > > (remove stable@dpdk.org) > > On Tue, 14 Mar 2017 10:46:40 +0100, Olivier Matz wrote: > > Hi Wei, > > > > On Thu, 16 Feb 2017 17:49:22 +0100, Olivier Matz wrote: > > > Hi Wei, > > > > > > On Thu, 9 Feb 2017 14:50:05 +0000, "Dai, Wei" wrote: > > > > > -----Original Message----- > > > > > From: Dai, Wei > > > > > Sent: Thursday, February 9, 2017 10:38 PM > > > > > To: 'Olivier Matz' ; dev@dpdk.org; Zhang, > > > > > Helin ; Ananyev, Konstantin > > > > > > > > > > Cc: Guo Fengtian ; stable@dpdk.org > > > > > Subject: RE: [dpdk-dev] [PATCH] net/ixgbevf: fix stats update after > > > > > a PF reset > > > > > > > > > > The stats register can rewind to zero when the port is running for > > > > > a long period. So I am afraid that this check is not always correct. > > > > > Why not introduce a variable to directly indicate whether the > > > > > resulted stats should be updated or not. > > > > > > > > Another way is to clear > > > > hw_stats->last_vfgprc/last_vfgorc/last_vfgptc/last_vfmprc at the same > > > > time PF is set down. > > > > > > > > > > Can we know easily in VF if the PF was set down? > > > > Any guideline for this? Or is it something we cannot fix? > > > > Is any maintainer available to help to fix that? > > Unfortunately I don't have enough knowledge on this driver to do the fix > by myself. It would be helpful to have some guidelines by a maintainer so > I can understand what is the proper way to fix the issue. > > Thanks, > Olivier