From: Thomas Monjalon <thomas@monjalon.net>
To: yanling.song@linux.dev, Yanling Song <songyl@ramaxel.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
dev@dpdk.org, yanggan@ramaxel.com, xuyun@ramaxel.com,
stephen@networkplumber.org, lihuisong@huawei.com,
Ziyang Xuan <xuanziyang2@huawei.com>,
Xiaoyun Wang <cloud.wangxiaoyun@huawei.com>,
Guoyang Zhou <zhouguoyang@huawei.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>
Subject: Re: [PATCH v6 00/26] Net/SPNIC: support SPNIC into DPDK 22.03
Date: Sun, 13 Feb 2022 19:07:09 +0100 [thread overview]
Message-ID: <19818625.Yz81rIOvuz@thomas> (raw)
In-Reply-To: <20220212220146.00007431@ramaxel.com>
12/02/2022 15:01, Yanling Song:
> On Fri, 21 Jan 2022 10:22:10 +0000
> Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> > On 1/21/2022 9:27 AM, Yanling Song wrote:
> > > On Wed, 19 Jan 2022 16:56:52 +0000
> > > Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> > >
> > >> On 12/30/2021 6:08 AM, Yanling Song wrote:
> > >>> The patchsets introduce SPNIC driver for Ramaxel's SPNxx serial
> > >>> NIC cards into DPDK 22.03. Ramaxel Memory Technology is a company
> > >>> which supply a lot of electric products: storage, communication,
> > >>> PCB... SPNxxx is a serial PCIE interface NIC cards:
> > >>> SPN110: 2 PORTs *25G
> > >>> SPN120: 4 PORTs *25G
> > >>> SPN130: 2 PORTs *100G
> > >>>
> > >>
> > >> Hi Yanling,
> > >>
> > >> As far as I can see hnic (from Huawei) and this spnic drivers are
> > >> alike, what is the relation between these two?
> > >
> > > It is hard to create a brand new driver from scratch, so we
> > > referenced to hinic driver when developing spnic.
> >
> > That is OK, but based on the familiarity of the code you may consider
> > keeping the original code Copyright, I didn't investigate in
> > that level but cc'ed hinic maintainers for info.
> > Also cc'ed Hemant for guidance.
What is the percentage of familiarity in the code?
> Sorry for late reponse since it was Spring Festival and I was in
> vacation, just back to work.
>
> Hemant gave the guidance already, but we do not want to keep another
> company's copyright in our code.
> How should we modify code so that the
> code meet DPDK's requirment and can be accepted with our copyright
> only?
If you don't want to keep a copyright, don't copy the code.
> > But my question was more related to the HW, is there any relation
> > between the hinic HW and spnic HW? Like one is derived from other
> > etc...
>
> I'm not clear what's the relation between hinic/spnic hw since we do
> not know what's the hinic hw.
Do you mean you are copying a driver and its design choices
without understanding what it does?
next prev parent reply other threads:[~2022-02-13 18:07 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-30 6:08 Yanling Song
2021-12-30 6:08 ` [PATCH v6 01/26] drivers/net: introduce a new PMD driver Yanling Song
2022-01-19 16:58 ` Ferruh Yigit
2021-12-30 6:08 ` [PATCH v6 02/26] net/spnic: initialize the HW interface Yanling Song
2022-01-19 17:05 ` Ferruh Yigit
2022-01-21 9:32 ` Yanling Song
2021-12-30 6:08 ` [PATCH v6 03/26] net/spnic: add mbox message channel Yanling Song
2021-12-30 6:08 ` [PATCH v6 04/26] net/spnic: introduce event queue Yanling Song
2021-12-30 6:08 ` [PATCH v6 05/26] net/spnic: add mgmt module Yanling Song
2022-01-19 17:22 ` Ferruh Yigit
2022-01-21 9:33 ` Yanling Song
2021-12-30 6:08 ` [PATCH v6 06/26] net/spnic: add cmdq and work queue Yanling Song
2021-12-30 6:08 ` [PATCH v6 07/26] net/spnic: add interface handling cmdq message Yanling Song
2021-12-30 6:08 ` [PATCH v6 08/26] net/spnic: add hardware info initialization Yanling Song
2021-12-30 6:08 ` [PATCH v6 09/26] net/spnic: support MAC and link event handling Yanling Song
2022-01-19 17:26 ` Ferruh Yigit
2022-01-21 9:36 ` Yanling Song
2021-12-30 6:08 ` [PATCH v6 10/26] net/spnic: add function info initialization Yanling Song
2021-12-30 6:08 ` [PATCH v6 11/26] net/spnic: add queue pairs context initialization Yanling Song
2021-12-30 6:08 ` [PATCH v6 12/26] net/spnic: support mbuf handling of Tx/Rx Yanling Song
2021-12-30 6:08 ` [PATCH v6 13/26] net/spnic: support Rx congfiguration Yanling Song
2021-12-30 6:08 ` [PATCH v6 14/26] net/spnic: add port/vport enable Yanling Song
2021-12-30 6:08 ` [PATCH v6 15/26] net/spnic: support IO packets handling Yanling Song
2021-12-30 6:08 ` [PATCH v6 16/26] net/spnic: add device configure/version/info Yanling Song
2021-12-30 6:08 ` [PATCH v6 17/26] net/spnic: support RSS configuration update and get Yanling Song
2021-12-30 6:08 ` [PATCH v6 18/26] net/spnic: support VLAN filtering and offloading Yanling Song
2021-12-30 6:08 ` [PATCH v6 19/26] net/spnic: support promiscuous and allmulticast Rx modes Yanling Song
2021-12-30 6:08 ` [PATCH v6 20/26] net/spnic: support flow control Yanling Song
2021-12-30 6:08 ` [PATCH v6 21/26] net/spnic: support getting Tx/Rx queues info Yanling Song
2021-12-30 6:09 ` [PATCH v6 22/26] net/spnic: net/spnic: support xstats statistics Yanling Song
2021-12-30 6:09 ` [PATCH v6 23/26] net/spnic: support VFIO interrupt Yanling Song
2021-12-30 6:09 ` [PATCH v6 24/26] net/spnic: support Tx/Rx queue start/stop Yanling Song
2021-12-30 6:09 ` [PATCH v6 25/26] net/spnic: add doc infrastructure Yanling Song
2022-01-19 17:27 ` Ferruh Yigit
2022-01-21 9:39 ` Yanling Song
2021-12-30 6:09 ` [PATCH v6 26/26] net/spnic: fixes unsafe C style code Yanling Song
2022-01-19 17:28 ` Ferruh Yigit
2022-01-21 9:40 ` Yanling Song
2022-01-19 16:56 ` [PATCH v6 00/26] Net/SPNIC: support SPNIC into DPDK 22.03 Ferruh Yigit
2022-01-21 9:27 ` Yanling Song
2022-01-21 10:22 ` Ferruh Yigit
2022-01-24 5:12 ` Hemant Agrawal
2022-02-12 14:01 ` Yanling Song
2022-02-13 18:07 ` Thomas Monjalon [this message]
2022-02-18 9:30 ` Yanling Song
2023-04-13 9:02 ` Ferruh Yigit
2023-07-31 14:08 ` Thomas Monjalon
2022-02-16 14:19 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19818625.Yz81rIOvuz@thomas \
--to=thomas@monjalon.net \
--cc=cloud.wangxiaoyun@huawei.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=lihuisong@huawei.com \
--cc=songyl@ramaxel.com \
--cc=stephen@networkplumber.org \
--cc=xuanziyang2@huawei.com \
--cc=xuyun@ramaxel.com \
--cc=yanggan@ramaxel.com \
--cc=yanling.song@linux.dev \
--cc=zhouguoyang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).