From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8EB9DA00C4; Sun, 13 Feb 2022 19:07:16 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 145D440DDA; Sun, 13 Feb 2022 19:07:16 +0100 (CET) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by mails.dpdk.org (Postfix) with ESMTP id 123D44068C for ; Sun, 13 Feb 2022 19:07:15 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.nyi.internal (Postfix) with ESMTP id 50CBD58015D; Sun, 13 Feb 2022 13:07:14 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sun, 13 Feb 2022 13:07:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; bh=GU2cJTzbU/xmMS OBRRgcHxwnl6Kx+yDkuDq8kTVsAiA=; b=ZXLQLAZ9+JAfSjZyaPehY/iU49+iw3 7M3mETDkN9flYGMo11BSrAKlK7xwRg2djIj7EtjzAMQA9CLdKjK0W555goL2y8if JvkziLU95miugNrGGXgjpRYO9v6lK1F63elb3o37aANaeMsjFd0DlgPzAYkUo8cT 5c2JggookztJTDUJn+TDG0QDyOr/QGOa8DXOhw1WHvBNhyfA1nMsUQDja/Su2RdA RPHipSEAJhTRb7cW3k47f/QBrQ1LjMGajTyXxAy/NIabGAMHNoaQNuqq2ZBesYEg qCPO76HMwLmvHA6GCz9RS8J7BFzacuoLqqpKvih8pH5zEoQGlgBp+ZsQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=GU2cJTzbU/xmMSOBRRgcHxwnl6Kx+yDkuDq8kTVsA iA=; b=M41xlfe0l9wHS5rW9//bdX84szar8U7dJVIubqFgn3K29QcoWkDe6cZdu 9onfQhefb7ofXYk1ea2BnhsZbHZ0ZPA2DpDzUtePLFI2YuSjAxBbrOqmCcC+BAls q2FVjVNT2M7rNCaBMRqYQwglUVXEInQJDdf1LDbNEYt6GKlZcskmu/aJforbHUxo RMueMX2D8CHsaB0327DMc+ndTg0ue/THP+/4yT2xQP0vqgkqVQeK5PY4XTQ9IiG+ mRSoY3CEF3hQyVvNybJUr0z4ru224MNqKP/GV/AgbpNYUUpogWgFzDL6NvP5ObvM e+QBP/uGKnBteAaiueBCFDvG8H0SA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrjedtgddutdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 13 Feb 2022 13:07:11 -0500 (EST) From: Thomas Monjalon To: yanling.song@linux.dev, Yanling Song Cc: Ferruh Yigit , dev@dpdk.org, yanggan@ramaxel.com, xuyun@ramaxel.com, stephen@networkplumber.org, lihuisong@huawei.com, Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , Hemant Agrawal Subject: Re: [PATCH v6 00/26] Net/SPNIC: support SPNIC into DPDK 22.03 Date: Sun, 13 Feb 2022 19:07:09 +0100 Message-ID: <19818625.Yz81rIOvuz@thomas> In-Reply-To: <20220212220146.00007431@ramaxel.com> References: <3982cadb-5b7e-22b4-d8e7-091ff22e4702@intel.com> <20220212220146.00007431@ramaxel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 12/02/2022 15:01, Yanling Song: > On Fri, 21 Jan 2022 10:22:10 +0000 > Ferruh Yigit wrote: > > > On 1/21/2022 9:27 AM, Yanling Song wrote: > > > On Wed, 19 Jan 2022 16:56:52 +0000 > > > Ferruh Yigit wrote: > > > > > >> On 12/30/2021 6:08 AM, Yanling Song wrote: > > >>> The patchsets introduce SPNIC driver for Ramaxel's SPNxx serial > > >>> NIC cards into DPDK 22.03. Ramaxel Memory Technology is a company > > >>> which supply a lot of electric products: storage, communication, > > >>> PCB... SPNxxx is a serial PCIE interface NIC cards: > > >>> SPN110: 2 PORTs *25G > > >>> SPN120: 4 PORTs *25G > > >>> SPN130: 2 PORTs *100G > > >>> > > >> > > >> Hi Yanling, > > >> > > >> As far as I can see hnic (from Huawei) and this spnic drivers are > > >> alike, what is the relation between these two? > > > > > > It is hard to create a brand new driver from scratch, so we > > > referenced to hinic driver when developing spnic. > > > > That is OK, but based on the familiarity of the code you may consider > > keeping the original code Copyright, I didn't investigate in > > that level but cc'ed hinic maintainers for info. > > Also cc'ed Hemant for guidance. What is the percentage of familiarity in the code? > Sorry for late reponse since it was Spring Festival and I was in > vacation, just back to work. > > Hemant gave the guidance already, but we do not want to keep another > company's copyright in our code. > How should we modify code so that the > code meet DPDK's requirment and can be accepted with our copyright > only? If you don't want to keep a copyright, don't copy the code. > > But my question was more related to the HW, is there any relation > > between the hinic HW and spnic HW? Like one is derived from other > > etc... > > I'm not clear what's the relation between hinic/spnic hw since we do > not know what's the hinic hw. Do you mean you are copying a driver and its design choices without understanding what it does?