From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com [209.85.212.172]) by dpdk.org (Postfix) with ESMTP id C8B808E93 for ; Tue, 20 Oct 2015 23:33:45 +0200 (CEST) Received: by wicll6 with SMTP id ll6so64626210wic.0 for ; Tue, 20 Oct 2015 14:33:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=zRW6CEqtNZATeaBF/V3z55sFiexFNr/GjZV+zBOELug=; b=MTjCpqSEIgXbrISiiPu0xlLoFXL4HemiIt+7eVQkUPsmwQNPYMvOclTsFxnlRGarQb frytGfeBx4QGFQouqS93PhPqcqozg/RDPRShg9GX1mmmpC8QWyZqyiDCNR+v5ML7RIY5 PQCD7Lh/pINNIRticUs3R1UI98XfQbs+0nEc8A0aJw9XImRkal0vm7WyuIoMK4oOLD1/ xKV3LMFd8RfcUaMoIYOPS8/Vm+VmZuGuOA4Ri7JTqFoT+a4+rLD4YHTH0Pufj5/VpbFW 5HW5e+CQS1BZy5vAlyJDNxxAC4inZx3qVGhmI/UVZbCE62pSwmId/NZsF+k3d6Mkuh/N UX4A== X-Gm-Message-State: ALoCoQlpO9m2khBXqFe4ZEMwijxp7fR79NhOJNqC/pYwaCcdOQd0MPKevUWW2qTZaxE6RqrWOg9g X-Received: by 10.180.72.113 with SMTP id c17mr6701859wiv.6.1445376825632; Tue, 20 Oct 2015 14:33:45 -0700 (PDT) Received: from xps13.localnet (guy78-1-82-235-116-147.fbx.proxad.net. [82.235.116.147]) by smtp.gmail.com with ESMTPSA id ds10sm20866767wib.24.2015.10.20.14.33.44 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Oct 2015 14:33:45 -0700 (PDT) From: Thomas Monjalon To: Bernard Iremonger Date: Tue, 20 Oct 2015 23:32:41 +0200 Message-ID: <1982089.GehIElVukW@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20151020114407.58972ed5@xeon-e3> References: <20151020114407.58972ed5@xeon-e3> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 1/2] virtio: fixed segmentation fault in queue_release X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Oct 2015 21:33:46 -0000 2015-10-20 11:44, Stephen Hemminger: > On Tue, 20 Oct 2015 16:37:41 +0100 > Bernard Iremonger wrote: > > > if input parameter vq is NULL, hw = vq->hw, causes a segmentation fault. > > > > Signed-off-by: Bernard Iremonger > > This could only happen for the case of the control vq. > Others are guaranteed to be non NULL by rte_ethdev. > > Acked-by: Stephen Hemminger Applied and merged with doc patch, thanks