DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Harry van Haaren <harry.van.haaren@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v4] eal: add function to check if primary proc alive
Date: Fri, 04 Mar 2016 19:07:33 +0100	[thread overview]
Message-ID: <1982135.2bKeWPYzB5@xps13> (raw)
In-Reply-To: <1456236612-30021-1-git-send-email-harry.van.haaren@intel.com>

I'm looking into details...

2016-02-23 14:10, Harry van Haaren:
>  EAL
>  ~~~
>  
> +* **Added rte_eal_primary_proc_alive() function**
> +
> +  A new function ``rte_eal_primary_proc_alive()`` has been added
> +  to allow the user to detect if a primary process is running.
> +  Use cases for this feature include fault detection, and monitoring
> +  using secondary processes.
>  

A space is missing here (2 lines before next title).

>  Drivers
>  ~~~~~~~
[...]
> + *   Copyright 2016 Intel Shannon Ltd. All rights reserved.

I had not noticed before. Intel Shannon Ltd is a separate entity?

[...]
> + * @return
> + *  - If alive, returns one.
> + *  - If dead, returns zero.

Why not use digits?

> + */
> +int rte_eal_primary_proc_alive(const char *config_file_path);
> +
> +

The functions are usually separated by only 1 line,
except in keepalive for an unknown reason.

  parent reply	other threads:[~2016-03-04 18:09 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-20 13:25 [dpdk-dev] [PATCH] " Harry van Haaren
2016-01-21  6:14 ` Qiu, Michael
2016-01-21  6:19   ` Matthew Hall
2016-01-21  9:02   ` Van Haaren, Harry
2016-01-22 17:37     ` Bruce Richardson
2016-01-25  8:06       ` Qiu, Michael
2016-01-25 11:44       ` Van Haaren, Harry
2016-01-26 19:13         ` Bruce Richardson
2016-01-27 10:35           ` Van Haaren, Harry
2016-01-25  8:11 ` Qiu, Michael
2016-01-25 11:51   ` Van Haaren, Harry
2016-01-26  2:25     ` Qiu, Michael
2016-01-26  9:04       ` Van Haaren, Harry
2016-01-26 11:07         ` Qiu, Michael
2016-01-26 11:19           ` Van Haaren, Harry
2016-01-27 10:31 ` [dpdk-dev] [PATCH v2] " Harry van Haaren
2016-02-02 14:11   ` [dpdk-dev] [PATCH v3] " Harry van Haaren
2016-02-23 14:10     ` [dpdk-dev] [PATCH v4] " Harry van Haaren
2016-02-24 13:50       ` Tahhan, Maryam
2016-03-04 18:07       ` Thomas Monjalon [this message]
2016-03-07 11:37       ` [dpdk-dev] [PATCH v5] " Harry van Haaren
2016-03-07 12:02         ` [dpdk-dev] [PATCH v6] " Harry van Haaren
2016-03-08  8:42           ` David Marchand
2016-03-08  9:58             ` Van Haaren, Harry
2016-03-08 11:13               ` Thomas Monjalon
2016-03-08 11:19                 ` David Marchand
2016-03-08 13:57                   ` Van Haaren, Harry
2016-03-08 14:40                     ` David Marchand
2016-03-08 17:07           ` [dpdk-dev] [PATCH v7 0/2] eal: add function to check primary alive Harry van Haaren
2016-03-08 17:07             ` [dpdk-dev] [PATCH v7 1/2] eal: fix race-condition in pri/sec proc startup Harry van Haaren
2016-03-08 17:07             ` [dpdk-dev] [PATCH v7 2/2] eal: add function to check if primary proc alive Harry van Haaren
2016-03-09 10:12             ` [dpdk-dev] [PATCH v8 0/2] eal: add function to check primary alive Harry van Haaren
2016-03-09 10:12               ` [dpdk-dev] [PATCH v8 1/2] eal: fix race-condition in pri/sec proc startup Harry van Haaren
2016-03-09 13:23                 ` Sergio Gonzalez Monroy
2016-03-09 10:12               ` [dpdk-dev] [PATCH v8 2/2] eal: add function to check if primary proc alive Harry van Haaren
2016-03-09 11:07               ` [dpdk-dev] [PATCH v8 0/2] eal: add function to check primary alive David Marchand
2016-03-09 12:59                 ` Sergio Gonzalez Monroy
2016-03-09 13:37               ` [dpdk-dev] [PATCH v9 " Harry van Haaren
2016-03-09 13:37                 ` [dpdk-dev] [PATCH v9 1/2] eal: fix race-condition in pri/sec proc startup Harry van Haaren
2016-03-09 14:27                   ` Sergio Gonzalez Monroy
2016-03-09 13:37                 ` [dpdk-dev] [PATCH v9 2/2] eal: add function to check if primary proc alive Harry van Haaren
2016-03-09 15:02                   ` Thomas Monjalon
2016-03-09 15:17                 ` [dpdk-dev] [PATCH v9 0/2] eal: add function to check primary alive Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1982135.2bKeWPYzB5@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=harry.van.haaren@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).