From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 9BAE72946 for ; Fri, 4 Mar 2016 19:09:10 +0100 (CET) Received: by mail-wm0-f49.google.com with SMTP id l68so30812772wml.0 for ; Fri, 04 Mar 2016 10:09:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=TOUSxMTsg7f43ny2UGo/0quDzPHjB5EuIGc7ESffma4=; b=nqIUyac5ZtUaZK9sD8gX1hT/lENlwGkyKp+DjR5YFOuK9VJKVGQepdSlCJqQ+eKsyi T9I4Tc39K5uTt7an8F0AVhfQ9+81f/QHED0z4LUqVG4VZyFqVsXiEYfKKMLqI60yKzmw 8VJ4HPpEO90szOM2Y+Ckq3SmPYo2rEVinQ8K04VB+/v53oMwn94dF+ge7kxq0ZCJAz9o +2Ryizw4ZxIOzLSFyMe0NCLJy1IYNiIQQ3qn5aWJDPpQjuF3ZHJxrYTRez89ZoOtg0m5 NWr5X32VeFMkuYZdhY5dlydDYl1XHJnF0toHxizMdVKjRU1W8igMD3OVianZJUZir9b1 Va7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=TOUSxMTsg7f43ny2UGo/0quDzPHjB5EuIGc7ESffma4=; b=FrHBje/XsEZCaUBswjyEkmYMSGounPFfqReJNRgp4yUfg11m5D3bMSz+YrfSeeTwAr ez4vX0uxm/BINav115Bl4FCKKW8FKDmPIzckzy2hAYy04kZbKVjDhTRmcRdvtHKpruDl R1l9+BU35ZWGRe2CTEnIfJTo8fbHj7jDr5qq8inHqIMvilA2v5EErOkgnlyyFd9wC9vF /HNdONxdiqOe49TNxy2GrAZqkpyObD84smdKxmVSUSzaLcqF9C4aw5Ldp3LUEfVUHdRf kCzUroSiSqbMW7xASdjKNzlsF8A6+otol3JRGha2mahJafzyU773jopI3qZVvfxGyaTQ 6UqA== X-Gm-Message-State: AD7BkJIUrBBlX9o/naCL5V4V4YtOOeAN62hq+HQYPUiPXfFdmbiwfBC1BMdH7z1FmzieoF6f X-Received: by 10.194.116.9 with SMTP id js9mr12348052wjb.112.1457114950489; Fri, 04 Mar 2016 10:09:10 -0800 (PST) Received: from xps13.localnet (171.36.101.84.rev.sfr.net. [84.101.36.171]) by smtp.gmail.com with ESMTPSA id 3sm217234wmp.14.2016.03.04.10.09.09 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 04 Mar 2016 10:09:09 -0800 (PST) From: Thomas Monjalon To: Harry van Haaren Date: Fri, 04 Mar 2016 19:07:33 +0100 Message-ID: <1982135.2bKeWPYzB5@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1456236612-30021-1-git-send-email-harry.van.haaren@intel.com> References: <1454422283-14025-1-git-send-email-harry.van.haaren@intel.com> <1456236612-30021-1-git-send-email-harry.van.haaren@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v4] eal: add function to check if primary proc alive X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Mar 2016 18:09:10 -0000 I'm looking into details... 2016-02-23 14:10, Harry van Haaren: > EAL > ~~~ > > +* **Added rte_eal_primary_proc_alive() function** > + > + A new function ``rte_eal_primary_proc_alive()`` has been added > + to allow the user to detect if a primary process is running. > + Use cases for this feature include fault detection, and monitoring > + using secondary processes. > A space is missing here (2 lines before next title). > Drivers > ~~~~~~~ [...] > + * Copyright 2016 Intel Shannon Ltd. All rights reserved. I had not noticed before. Intel Shannon Ltd is a separate entity? [...] > + * @return > + * - If alive, returns one. > + * - If dead, returns zero. Why not use digits? > + */ > +int rte_eal_primary_proc_alive(const char *config_file_path); > + > + The functions are usually separated by only 1 line, except in keepalive for an unknown reason.