From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id 317B437AF for ; Mon, 2 Nov 2015 09:24:48 +0100 (CET) Received: by wmeg8 with SMTP id g8so53609654wme.1 for ; Mon, 02 Nov 2015 00:24:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind_com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=wrl1fCFyyiWd1FNQ4Ot45MCAvNq1uPxLAR3qloC0E/w=; b=isoi8pWZvAbK4b7r9oS40YgJfCtpGSL7by6I+GDfyiNe9aso1qoaQULm8UdqKSqtI3 xIGUk/eUg+XbqzcQTXSeFpxDn4ki2icoOrvq5O7n+7q9j72eAeu9YtOUbf3nXgcHJAaZ wKkC3LeAQEYdy5/pb2mXwROZkY19LwppTkWzuBBhNVMylSSdzImY9uB2HSPgrizzJbcl eax29qxfFIK+834U2jWp/erY4k8PLzfj+ZIBK6Dgl3UMJXWEZJM0xjvuQN3fNsOtAZ/K cZenEZEPk25+VuFiyfkIS+CUdyNfsOCTSzMP3BaUZtoIxc+l0pIB4EUy4ikH3Fl20F0Q CrUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=wrl1fCFyyiWd1FNQ4Ot45MCAvNq1uPxLAR3qloC0E/w=; b=Un5HU6dR7HcILjr6zg58OvvzGmmAG5yFIyCZFw/UKUA31aURVuUsr/BjVrPCsnq06u XpoGvnhOJT89MTF34GkZdC0xJRF0xkFcowfZa9eetjLXDkQPIgbvFNYcchLiUNFNJKoM tT9dIo088w2KssOZpkuPdvDUxSaUqRgmF72nBHxUvtWjbUisXT9bZdKrNe09shFTq7ej +abZIPFE1jPT7Ibd5tM9Od8UCABPm4XE4pI24yFOf0LH2X44pfAvR7kC/5L80q2uhile phkQ99CuzgCub787k0uvn7XHIfnFvO3NGBaE7WDux8hTQfZNgl/5i7jnqeO82JhUyZ4J 3sjA== X-Gm-Message-State: ALoCoQloLt0b+H0Y0YCoi7jAPCAkgScnuE+inX3935ReQAGOkzgpG1Fxb0+UdMJUd+PouD38u1cX X-Received: by 10.28.17.71 with SMTP id 68mr10960163wmr.59.1446452688080; Mon, 02 Nov 2015 00:24:48 -0800 (PST) Received: from xps13.localnet (144.16.90.92.rev.sfr.net. [92.90.16.144]) by smtp.gmail.com with ESMTPSA id kd8sm4893338wjc.27.2015.11.02.00.24.47 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 02 Nov 2015 00:24:47 -0800 (PST) From: Thomas Monjalon To: "Zhang, Helin" Date: Mon, 02 Nov 2015 09:23:30 +0100 Message-ID: <19825744.IikEuoS3RC@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1446098572-4409-1-git-send-email-helin.zhang@intel.com> <3367355.V0LI0AXumx@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v7 1/2] i40e: RSS/FD granularity configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Nov 2015 08:24:48 -0000 2015-11-02 07:59, Zhang, Helin: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > 2015-11-02 02:11, Zhang, Helin: > > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > > 2015-10-30 11:11, Helin Zhang: > > > > > v7 changes: > > > > > Modified RTE_ETH_INSET_SIZE_MAX from 128 to 1, to avoid ABI changes. > > > > > > > > Why it would avoid ABI changes? > > > > Have you passed the ABI checker? > > > > > > Hi Thomas > > > > > > The only structure modified is ' struct rte_eth_hash_filter_info ', > > > where a new element (struct rte_eth_input_set_conf input_set_conf) was > > > added. But I kept its structure the same size as another one (struct > > > rte_eth_hash_global_conf global_conf) already in that union, they are > > > both in 12 bytes. That means nothing changed for ' struct > > rte_eth_hash_filter_info'. > > > > First, it should be justified in the commit message. > > Second, I think it's wrong: > > The union has struct rte_eth_hash_global_conf = enum + uint32_t + uint32_t You > > are adding struct rte_eth_input_set_conf = uint16_t + uint16_t + enum + enum > > I'm not sure we can assume the sizes are the same. > Oh, yes, the size might not be the same on all platforms. > > > > > The ethdev ABI is already broken in this release. So maybe we can agree that it's > > not a big deal but it should be notified in the release notes and, in this case, you > > could keep your original patch with 128 enums. > That's bad, but good for me. Can I just enable v6 as 'new', and disable 'v7'? > Or I need a new version? I think you need a new version to notify ABI change in the release notes.