From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 93E98A0519; Mon, 22 Jun 2020 16:54:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2C4C31D72A; Mon, 22 Jun 2020 16:54:46 +0200 (CEST) Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by dpdk.org (Postfix) with ESMTP id AB2951D728 for ; Mon, 22 Jun 2020 16:54:44 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 173205802AB; Mon, 22 Jun 2020 10:54:44 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Mon, 22 Jun 2020 10:54:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= EyUhGp8Uk+9Wwir6gFctWF/jEfoiIf2bI+YlU1DT51Y=; b=nwuW5/MtRUxGEOOA yOvT7kYWBuKyaE0I6wIpo8QWniISZmgjYXfSjnM6HVDMHhTPjT1lEJKV+/NFpVlh Uk22L3ktlU8fUcbQ8x7LKi07f87R1ocXXOOOhN50yaZxPpKq4Ry5cPp57V1/6yLm azbVy9bUK8oWzLZIoe46Tb2B5VTPsKx6tO/1zI9BVwYFtjpn9hb4KCmgB2CJV3u/ ZQH3MwKOn1jmBN3TnQmewF6X2EzJuZhaNbyj02/Do78FLH0c8IiFnXOJHp/HvPgT LV0Ixfa3YldRBRz5xab3EadB7fkUeFNpaSWJ3sKJNSwv5PcfO6FfGjHxQhBWC0/Q waEhrw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=EyUhGp8Uk+9Wwir6gFctWF/jEfoiIf2bI+YlU1DT5 1Y=; b=dJLxzuHwZ19rBIYCMSEIq0hMjOHprgQHai6s9lfK8kv6oqKvP/0At/FwQ dg1GgNS+KJX9f5wg5orgvXUGKoL8ugQknUppuvcBa0OlXVlNxzyf6k6j/RATDJ+m eHC3dXnKoFOAfTNgFncaO+vAX0UP7wri6PrB/QvC5aToePTa8LjVDt8XYhPA08lX eVCbQmlYwW8tBGZD888nmmC9xNCDoDaCd4NJGP7G3TdZxWHK80atgzP3jR1YxJ9u 9M27XQ/sY/z6XG8AL/N1ZAd8gCuHMJtdDCbOnrUxxAw5gxVPoKYnIDO68WUjvwRA hdhJnEYEUnECofD3uZnQ8beOoTAag== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudekvddgkeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id AC666328006B; Mon, 22 Jun 2020 10:54:41 -0400 (EDT) From: Thomas Monjalon To: Tal Shnaiderman Cc: dev@dpdk.org, pallavi.kadam@intel.com, dmitry.kozliuk@gmail.com, david.marchand@redhat.com, grive@u256.net, ranjit.menon@intel.com, navasile@linux.microsoft.com, harini.ramakrishnan@microsoft.com, ocardona@microsoft.com, anatoly.burakov@intel.com, fady@mellanox.com, bruce.richardson@intel.com Date: Mon, 22 Jun 2020 16:54:40 +0200 Message-ID: <1982686.VIimsLeXWE@thomas> In-Reply-To: <20200622075529.24180-2-talshn@mellanox.com> References: <20200621102612.22740-2-talshn@mellanox.com> <20200622075529.24180-1-talshn@mellanox.com> <20200622075529.24180-2-talshn@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v8 1/9] eal: move OS common functions to single file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Can we reduce the scope in the title? This patch is about EAL config in general, so I would reword it to: eal: move OS common config objects 22/06/2020 09:55, talshn@mellanox.com: > +#include > + > +#include > +#include Local files, like eal_*, are usually included with "". [...] > +/* Allow the application to print its usage message too if set */ > +static rte_usage_hook_t rte_application_usage_hook; This is not config-related. Could it be in a separate patch? Moved to lib/librte_eal/common/eal_common_options.c? [...] > +void > +rte_eal_set_runtime_dir(char *run_dir, size_t size) > +{ > + strncpy(runtime_dir, run_dir, size); > +} This function should be private to EAL, no rte_ prefix. [...] > +/* Return a pointer to theinternal configuration structure */ Space missing > +struct internal_config * > +rte_eal_get_internal_configuration(void) > +{ > + return &internal_config; > +} This function should be private to EAL, no rte_ prefix. [...] > --- a/lib/librte_eal/include/rte_eal.h > +++ b/lib/librte_eal/include/rte_eal.h > +void > +rte_eal_set_runtime_dir(char *run_dir, size_t size); > + > +void > +rte_eal_config_remap(void *mem_cfg_addr); > + > +struct internal_config * > +rte_eal_get_internal_configuration(void); > + > +rte_usage_hook_t * > +rte_eal_get_application_usage_hook(void); If some new function must be added in the API, they must be clearly documented with doxygen. But as part of this refactoring, I guess we should have zero new API. Probably that those 4 functions are candidate to internal header files.