From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f50.google.com (mail-wg0-f50.google.com [74.125.82.50])
 by dpdk.org (Postfix) with ESMTP id 788979655
 for <dev@dpdk.org>; Mon, 20 Jul 2015 01:24:56 +0200 (CEST)
Received: by wgav7 with SMTP id v7so52954524wga.2
 for <dev@dpdk.org>; Sun, 19 Jul 2015 16:24:56 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=4prg1mzixK2kaLPgFO+hnIuHcwL9+RxCU1gHr1DErz8=;
 b=kpRIXMhhrQGLZg60t45K28gNLQH/TNVYc6j2mH7BgwP1ya98xT8JO3nhhKoAVhWSVt
 H7/IcnQjvuEaNbtGrLvl5N0WLtAOw2BTRZ8UTA6FmCAxTc7+8hZUUW2j0YESiLanYV4x
 G5VcSZodPLd44QtsUssYmQhOzNqwRtN0GyRVe9fnhr51HYRY+9krTFG5jHkZlhJK8OQ6
 di2SCt3MgBcMtE231w9CK5jhqiYdbYmIaGPQrKOFIQriW7ER4faWuVnKjCgkfymikkrY
 XQIKN37dU0BxeVWYTaNvSGi16eMhR5H5JgAxmRpfEqrAoKbGfdHE0ZgbnXoN8Z4JbKPD
 PiMQ==
X-Gm-Message-State: ALoCoQnji8ZA4evUPmw2PDM5nd5+xUOBFmkwR78GgCYC5QA45/fv9qkg8s+L/GRjBs/55okHPbMG
X-Received: by 10.180.9.6 with SMTP id v6mr16189032wia.83.1437348296282;
 Sun, 19 Jul 2015 16:24:56 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by smtp.gmail.com with ESMTPSA id dl10sm29159580wjb.42.2015.07.19.16.24.55
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Sun, 19 Jul 2015 16:24:55 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
Date: Mon, 20 Jul 2015 01:23:45 +0200
Message-ID: <1983160.fsyPZ7InvC@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; )
In-Reply-To: <4ddacaea168239cb2fdccfacf44906b57948f190.1437156076.git.rahul.lakkireddy@chelsio.com>
References: <cover.1437156076.git.rahul.lakkireddy@chelsio.com>
 <4ddacaea168239cb2fdccfacf44906b57948f190.1437156076.git.rahul.lakkireddy@chelsio.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org, Felix Marti <felix@chelsio.com>,
 Nirranjan Kirubaharan <nirranjan@chelsio.com>,
 Kumar Sanghvi <kumaras@chelsio.com>
Subject: Re: [dpdk-dev] [PATCH 1/3] nic_uio: Fix to allow any device to be
	bound to nic_uio
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 19 Jul 2015 23:24:56 -0000

2015-07-17 23:50, Rahul Lakkireddy:
> nic_uio requires the pci ids to be present in rte_pci_dev_ids.h in order to
> bind the devices to nic_uio.  However, it's better to remove this whitelist of
> pci ids, and instead rely on hw.nic_uio.bdfs kenv parameter to allow binding
> any device to nic_uio.
[...]
> -	for (i = 0; i < NUM_DEVICES; i++)
> -		if (pci_get_vendor(dev) == devices[i].vend &&
> -			pci_get_device(dev) == devices[i].dev) {
> -
> +	for (i = 0; i < num_detached; i++)
> +		if (pci_get_vendor(dev) == pci_get_vendor(detached_devices[i]) &&
> +		    pci_get_device(dev) == pci_get_device(detached_devices[i])) {
>  			device_set_desc(dev, "Intel(R) DPDK PCI Device");

This is an old name. You can now rename "Intel(R) DPDK" to "DPDK".