* [dpdk-dev] [PATCH] nfp: tx checksum offload fixes
@ 2016-03-03 10:08 Alejandro Lucero
2016-03-03 10:14 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Alejandro Lucero @ 2016-03-03 10:08 UTC (permalink / raw)
To: dev
Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
---
drivers/net/nfp/nfp_net.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
index fd4dd39..6078e9f 100644
--- a/drivers/net/nfp/nfp_net.c
+++ b/drivers/net/nfp/nfp_net.c
@@ -1522,7 +1522,7 @@ static inline void
nfp_net_tx_cksum(struct nfp_net_txq *txq, struct nfp_net_tx_desc *txd,
struct rte_mbuf *mb)
{
- uint16_t ol_flags;
+ uint64_t ol_flags;
struct nfp_net_hw *hw = txq->hw;
if (!(hw->cap & NFP_NET_CFG_CTRL_TXCSUM))
@@ -1543,7 +1543,8 @@ nfp_net_tx_cksum(struct nfp_net_txq *txq, struct nfp_net_tx_desc *txd,
break;
}
- txd->flags |= PCIE_DESC_TX_CSUM;
+ if (ol_flags & (PKT_TX_IP_CKSUM | PKT_TX_L4_MASK))
+ txd->flags |= PCIE_DESC_TX_CSUM;
}
/* nfp_net_rx_cksum - set mbuf checksum flags based on RX descriptor flags */
--
1.7.9.5
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] nfp: tx checksum offload fixes
2016-03-03 10:08 [dpdk-dev] [PATCH] nfp: tx checksum offload fixes Alejandro Lucero
@ 2016-03-03 10:14 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2016-03-03 10:14 UTC (permalink / raw)
To: Alejandro Lucero; +Cc: dev
Hi Alejandro,
Please start the title with a verb (fix here),
describe briefly the bug,
and add a Fixes: tag.
More info in this doc:
http://dpdk.org/doc/guides/contributing/patches.html#commit-messages-subject-line
2016-03-03 10:08, Alejandro Lucero:
> Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
> ---
> drivers/net/nfp/nfp_net.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-03 10:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-03 10:08 [dpdk-dev] [PATCH] nfp: tx checksum offload fixes Alejandro Lucero
2016-03-03 10:14 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).