From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CB92242D26; Thu, 22 Jun 2023 20:35:25 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9BD3240DDA; Thu, 22 Jun 2023 20:35:25 +0200 (CEST) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mails.dpdk.org (Postfix) with ESMTP id 99446406BA for ; Thu, 22 Jun 2023 20:35:24 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id C54E93200645; Thu, 22 Jun 2023 14:35:20 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 22 Jun 2023 14:35:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1687458920; x=1687545320; bh=LNg6+kPlX8RcsTcsm9b0VDMRWoY0GRqud4o Ibr4cVsE=; b=T12bl2WKqPwcQYGsaoJ50KjK9Q/JmadGezpwBQVU/pfk5xpGLhI EhbiDhoSiknvbZynaB+XsdHT2gi/y2x+V28wtM9HBabJWRdt2EMbGtTdROq3lr2x FVjt3lGAGFPnxKj+NRQRmpEry8A4agzkw+5KQtpveCNKQOnqRJFskXYIjJ496K/+ ck86N6N8DsKiwSaknGQS3GbTiHcuPwvCAOaUmEQO4UgBZwi94rgqgg7A0/JryUMo GjoIOomn86FZluJPz2XZnOsbSDHLlIV2RgS2sUiQ/Yh4kYnjHlGUH527TCaRcApL MhKEm29KR10ZeiA0GnUuT/j4LHi4mIkkTHg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1687458920; x=1687545320; bh=LNg6+kPlX8RcsTcsm9b0VDMRWoY0GRqud4o Ibr4cVsE=; b=o+J6/T+9LjjBHgbcvubLDmRbnYR1YwAz62BkXDFGQIgCyTrKt/P JkTv5AtQAEdoAZV0+VkMsNNlGobAPX3tXixoXu/lSOgV9v1ww+DcqTa9xZ7UubWF 2npqHTolDpEQxCDBYG1rOlsPYxH/gJgBnZ9/2WorYvfZeYGkFDYd7rxMhMWAPpYE NpyESZYKBCEz2df5zY+U3euQENWSBSslJZe28lWk0h43p67iLBDQwARD9WZwsxdH jRyuRfP7j6sLnCZUcXxdcQtzTkCmHhrcdPWWXFDCr8/zUP61u1Uji6ES/cclHyng EhxlRsPxO6pzUsLlU7WfQu2+KCvN25NVxmA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgeeguddguddvjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnheptddtgffgfeduveefhffhffevfeeltdefhfduffeiffefkedt fefghfejgfetjeelnecuffhomhgrihhnpehmvghsohhnsghuihhlugdrtghomhdprhgvph hlrggtvggurdgtihdplhhinhhugidqsghuihhlugdrshhhnecuvehluhhsthgvrhfuihii vgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonh drnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 22 Jun 2023 14:35:19 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, david.marchand@redhat.com Subject: Re: [PATCH v3] doc: prefer installing using meson rather than ninja Date: Thu, 22 Jun 2023 20:35:17 +0200 Message-ID: <1986946.PIDvDuAF1L@thomas> In-Reply-To: <20230609145107.144593-1-bruce.richardson@intel.com> References: <20230609105139.76239-1-bruce.richardson@intel.com> <20230609145107.144593-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 09/06/2023 16:51, Bruce Richardson: > After doing a build, to install DPDK system-wide our documentation > recommended using the "ninja install" command. However, for anyone > building as a non-root user and only installing as root, the "meson > install" command is a better alternative, as it provides for > automatically dropping or elevating privileges as necessary in more > recent meson releases [1]. > > [1] https://mesonbuild.com/Installing.html#installing-as-the-superuser > > Signed-off-by: Bruce Richardson > > --- > V3: > * correct order of arguments to meson in CI scripts. The "-C" option > must follow the meson "install" command. [This is consistent with > other uses e.g. meson compile -C ..., meson test -C ...] > > V2: > * Fix one missed reference to "ninja install" in Linux GSG > * Changed CI scripts to use "meson install" to ensure step is properly > tested. > --- > .ci/linux-build.sh | 4 ++-- > doc/guides/contributing/coding_style.rst | 2 +- > doc/guides/cryptodevs/uadk.rst | 2 +- > doc/guides/freebsd_gsg/build_dpdk.rst | 2 +- > doc/guides/freebsd_gsg/build_sample_apps.rst | 2 +- > doc/guides/linux_gsg/build_dpdk.rst | 4 ++-- > doc/guides/prog_guide/build-sdk-meson.rst | 4 ++-- > 7 files changed, 10 insertions(+), 10 deletions(-) I see other occurences which could be replaced: .ci/linux-build.sh: [ -d install ] || DESTDIR=$(pwd)/install ninja -C build install devtools/test-meson-builds.sh: echo "DESTDIR=$2 $ninja_cmd -C $1 install" >&$verbose devtools/test-meson-builds.sh: DESTDIR=$2 $ninja_cmd -C $1 install >&$veryverbose doc/guides/nics/mlx4.rst: ninja install doc/guides/platform/mlx5.rst: ninja install