From: Thomas Monjalon <thomas@monjalon.net>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: dev@dpdk.org, stable@dpdk.org, stable@dpdk.org,
Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
Dmitry Malloy <dmitrym@microsoft.com>,
Pallavi Kadam <pallavi.kadam@intel.com>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] eal/windows: do not install virt2phys header
Date: Mon, 11 Oct 2021 21:07:23 +0200 [thread overview]
Message-ID: <1987625.VQ3m8ipJx8@thomas> (raw)
In-Reply-To: <20211001163726.78308-2-dmitry.kozliuk@gmail.com>
01/10/2021 18:37, Dmitry Kozlyuk:
> The header was not intended to be a public one.
> DPDK users should use `rte_mem_virt2iova()` to translate addresses.
> Other virt2phys users should use the header from the driver instead.
>
> Fixes: 2a5d547a4a9b ("eal/windows: implement basic memory management")
> Cc: stable@dpdk.org
>
> Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> ---
> headers += files(
> 'rte_os.h',
> - 'rte_virt2phys.h',
> 'rte_windows.h',
> )
We should plan to rename it.
Files starting with rte_ are supposed to be public.
next prev parent reply other threads:[~2021-10-11 19:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 16:37 [dpdk-dev] [PATCH 0/2] buildtools: enable chkincs on Windows Dmitry Kozlyuk
2021-10-01 16:37 ` [dpdk-dev] [PATCH 1/2] eal/windows: do not install virt2phys header Dmitry Kozlyuk
2021-10-11 19:07 ` Thomas Monjalon [this message]
2021-10-24 21:58 ` [dpdk-dev] [dpdk-stable] " Dmitry Kozlyuk
2021-10-01 16:37 ` [dpdk-dev] [PATCH 2/2] buildtools: enable chkincs on Windows Dmitry Kozlyuk
2021-10-01 16:39 ` Bruce Richardson
2021-10-11 19:10 ` [dpdk-dev] [PATCH 0/2] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1987625.VQ3m8ipJx8@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=dmitrym@microsoft.com \
--cc=navasile@linux.microsoft.com \
--cc=pallavi.kadam@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).