From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C5997A034F; Mon, 11 Oct 2021 21:07:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3638B41139; Mon, 11 Oct 2021 21:07:29 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 724164111C; Mon, 11 Oct 2021 21:07:28 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 26D185C0184; Mon, 11 Oct 2021 15:07:28 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Mon, 11 Oct 2021 15:07:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= sm+0B7+aXaU9/jX92sR72wHCn29c/1v+w4Atfa13VNw=; b=D++uwFpKvI7UxKBK t6j1IL1L59XpVX1WTd3fNKCwIsb3BLf+PMICcfXR0gWCRl6GBW+KIPI1t+6aqDBV mCj/4RYdaXHC5GFvmS96THwou5Qoq/Meldb0t7xC/c+FU186Ndp5a1zJZLsKxYAe y9hX2JZ6MTVng34xSK1gFDoMf6YXjZNTQsy5Q+VWQLRlNmFsvHYcsVkWu8rBasWJ IotYTgF700Wahl+CVt1gGZPdcBgTaPb14cFnoa4V+uRc9sNs+CS33QrJ3V6rfVHH UVXZwMWcGuyG20YuGgQBi5p6PyTdOXMeeAQ9IKfA9jKM3XxwPKOf5jSlN8ccn+E4 gBJrHQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=sm+0B7+aXaU9/jX92sR72wHCn29c/1v+w4Atfa13V Nw=; b=EuMHjHCMI3b1XZIQI73tBlSw+iF0fIPxxdFG8PPf64kItkGJ1Ga5yMgqA U89OX4YhkFm7U7hBrMbwKbyptDPJSRL6bTzGUTknsVgQQlt2roMypDGcC8qCr0/q ZUzruky8aWupiznf1nzuaCHNcDKSUiqx04v29Mfg2V+HaTUNYwPN71eaRtoJWwEX N46ruMe07u3IhS4CNHteDG2+PECOUFT54O/2fabOIvcip4jHJuZNGruEL/EMOs0j jm3x0Uo/7kqBZfbrOhtygndwprY2S3X7i1977N1AgqfI2nUt0Va3MgeesLeCiy38 UjpEqXxZWxBLNclgUoIc5MRYP9PoA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvddtiedguddvjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 11 Oct 2021 15:07:25 -0400 (EDT) From: Thomas Monjalon To: Dmitry Kozlyuk Cc: dev@dpdk.org, stable@dpdk.org, stable@dpdk.org, Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam Date: Mon, 11 Oct 2021 21:07:23 +0200 Message-ID: <1987625.VQ3m8ipJx8@thomas> In-Reply-To: <20211001163726.78308-2-dmitry.kozliuk@gmail.com> References: <20211001163726.78308-1-dmitry.kozliuk@gmail.com> <20211001163726.78308-2-dmitry.kozliuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] eal/windows: do not install virt2phys header X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 01/10/2021 18:37, Dmitry Kozlyuk: > The header was not intended to be a public one. > DPDK users should use `rte_mem_virt2iova()` to translate addresses. > Other virt2phys users should use the header from the driver instead. > > Fixes: 2a5d547a4a9b ("eal/windows: implement basic memory management") > Cc: stable@dpdk.org > > Signed-off-by: Dmitry Kozlyuk > --- > headers += files( > 'rte_os.h', > - 'rte_virt2phys.h', > 'rte_windows.h', > ) We should plan to rename it. Files starting with rte_ are supposed to be public.