From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2CEF7A04A5; Tue, 16 Jun 2020 21:17:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EC6641BFA4; Tue, 16 Jun 2020 21:17:33 +0200 (CEST) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by dpdk.org (Postfix) with ESMTP id 316471BFA3 for ; Tue, 16 Jun 2020 21:17:32 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 787FB58015A; Tue, 16 Jun 2020 15:17:31 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Tue, 16 Jun 2020 15:17:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= HDCD2ZUIK8GaRL/QpiNEluP4SLxsbDutRHvVyljq0FM=; b=EF7nKxgqkz3cn4ag f3uqJsRt7lKseGLqC7OShYwOBqyMJOlVS7s7vCmb1raIbBYDSWHYLALg3BOxqzDO Ep/0lkTEYWh6kg/47Hc9oebv3szY2nhdyrOLhqcSv2Vz9PfgSvprHkMijy1oOgoN C0aO5/H5U0KYnBhEzlNEMZxtQJku5m1lVD1NaEW/CJO5BfLme177dPtLlaqfsceS ryl+wv/ZjMvTp6tpQSkTuIu72/rIJVt7tuhhL1BRPv5bJV1qusaR/62iLkWWXEga /ZkpJ0PTkZR2Klwe08FGjHNMXwnSPN961dWzwjmuqMWaK/M8WXFcWXcokGCuCwZO FthAQw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=HDCD2ZUIK8GaRL/QpiNEluP4SLxsbDutRHvVyljq0 FM=; b=fWTHHROsdnwoaQtK0xvayLAmJYrxjK5GrvXQzVBghS/PXZLu602bNPJUv oxO1+3ePusXHdpBlydwdqp4yqJGJKxKMsR/txfANydQ+0nQR8DmmnR/4NEo9Foy1 U8MWHUeDQfIYoMFDE+jWGDFSLF+3hazUFYmgP7xlxP6W5NIDDp8DXEWuLo9NRcVl qm59f/9pwWDX8okoRIuKT4bBAVk6xOz1nGeenWjj5ooAm/iviJJPo9gtkdFUXIkg 3T8D+uwMfWDW03RG2iOeWQ+ycW9oQFPlAD1orIi4YtI/6IMrpSyM1XA2RVyB9eYh XqaxVwt1Kyy2Ts2LRIN73kDvol97g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudejtddgudefjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B06E530614FA; Tue, 16 Jun 2020 15:17:29 -0400 (EDT) From: Thomas Monjalon To: "dmitry.kozliuk@gmail.com" , Tasnim Bashar Cc: "dev@dpdk.org" , "harini.ramakrishnan@microsoft.com" , "pallavi.kadam@intel.com" , "ranjit.menon@intel.com" , "ocardona@microsoft.com" , "navasile@linux.microsoft.com" , Tal Shnaiderman , Fady Bader , Ophir Munk Date: Tue, 16 Jun 2020 21:17:27 +0200 Message-ID: <199043081.H7jX1ncZh2@thomas> In-Reply-To: References: <20200522001112.48932-1-tbashar@mellanox.com> <1716943.Gv3JEJsLzV@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] eal/windows: fix invalid thread handle X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 16/06/2020 20:53, Tasnim Bashar: > > From: Thomas Monjalon > > 02/06/2020 04:00, Tasnim Bashar: > > > Casting thread ID to handle is not accurate way to get thread handle. > > > Need to use OpenThread function to get thread handle from thread ID. > > > > > > pthread_setaffinity_np and pthread_getaffinity_np functions for > > > Windows are affected because of it. > > > > > > Signed-off-by: Tasnim Bashar > > > --- > > > v3: WA to remove warning(-Wmaybe-uninitialized) > > > > The -Wmaybe-uninitialized warning was there before this patch. > > Shouldn't it be a separate patch before this one? > > The warning appeared only on this patch, so we don't need to separate it I can see the warning on the main repo when cross-compiling with MinGW on Linux. [...] > > > + memset(cpuset, 0, sizeof(rte_cpuset_t)); > > > > Shouldn't we use RTE_CPU_ZERO instead of memset? > > If we use CPU_ZERO or CPU_SET, we still get the same warning! That's strange. Does it mean CPU_ZERO is broken in lib/librte_eal/windows/include/sched.h ?