From: Thomas Monjalon <thomas@monjalon.net>
To: Konstantin Ananyev <konstantin.ananyev@intel.com>
Cc: stable@dpdk.org, dev@dpdk.org, ryan.e.hall@intel.com,
alexander.v.gutkin@intel.com
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] ip_frag: check fragment length of incoming packet
Date: Mon, 05 Nov 2018 12:37:31 +0100 [thread overview]
Message-ID: <1990999.tdZQoCF3K1@xps> (raw)
In-Reply-To: <1541413603-4792-2-git-send-email-konstantin.ananyev@intel.com>
05/11/2018 11:26, Konstantin Ananyev:
> Under some conditions ill-formed fragments might cause
> reassembly code to corrupt mbufs and/or crash.
> Let say the following fragments sequence:
> <ofs=0,len=100, flags=MF>
> <ofs=96,len=100, flags=MF>
> <ofs=200,len=0,flags=MF>
> <ofs=200,len=100,flags=0>
> can trigger the problem.
> To overcome such situation, added check that fragment length
> of incoming value is greater than zero.
>
> Reported-by: <ryan.e.hall@intel.com>
> Reported-by: <alexander.v.gutkin@intel.com>
Please, could you provide the full names?
Note: it is usually inserted just before your Signed-off.
> Fixes: 601e279df074 ("ip_frag: move fragmentation/reassembly headers into a library")
> Fixes: 4f1a8f633862 ("ip_frag: add IPv6 reassembly")
> Cc: stable@dpdk.org
>
> Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
next prev parent reply other threads:[~2018-11-05 11:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 10:26 [dpdk-dev] [PATCH 0/2] ip_frag: two fixes in reassembly code Konstantin Ananyev
2018-11-05 10:26 ` [dpdk-dev] [PATCH 1/2] ip_frag: check fragment length of incoming packet Konstantin Ananyev
2018-11-05 11:37 ` Thomas Monjalon [this message]
2018-11-05 10:26 ` [dpdk-dev] [PATCH 2/2] ip_frag: use key length for key comparision Konstantin Ananyev
2018-11-05 12:11 ` [dpdk-dev] [PATCH v2 0/2] ip_frag: two fixes in reassembly code Konstantin Ananyev
2018-11-05 12:11 ` [dpdk-dev] [PATCH v2 1/2] ip_frag: check fragment length of incoming packet Konstantin Ananyev
2018-11-05 12:11 ` [dpdk-dev] [PATCH 2/2] ip_frag: use key length for key comparision Konstantin Ananyev
2018-11-05 12:18 ` [dpdk-dev] [PATCH v2 0/2] ip_frag: two fixes in reassembly code Konstantin Ananyev
2018-11-06 0:58 ` Thomas Monjalon
2018-11-05 12:18 ` [dpdk-dev] [PATCH v2 1/2] ip_frag: check fragment length of incoming packet Konstantin Ananyev
2018-11-05 12:18 ` [dpdk-dev] [PATCH v2 2/2] ip_frag: use key length for key comparision Konstantin Ananyev
2018-11-06 10:53 ` Burakov, Anatoly
2018-11-06 11:41 ` Ananyev, Konstantin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1990999.tdZQoCF3K1@xps \
--to=thomas@monjalon.net \
--cc=alexander.v.gutkin@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=ryan.e.hall@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).