From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com [209.85.212.182]) by dpdk.org (Postfix) with ESMTP id 516BAC324 for ; Tue, 16 Jun 2015 17:32:53 +0200 (CEST) Received: by wicnd19 with SMTP id nd19so2036420wic.1 for ; Tue, 16 Jun 2015 08:32:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=RUQg4dMJjcI64vitbC9cCN/yIkYHdrI059v8FMC5iUg=; b=gArzamaFfwIi7wToBbCSzFlQAyXNuc4FXsXkkQKYZBvkTbztg0XbCYCxGmLsRauoUa BLE6rcuSnf7HDgz3eIISuzmqE7ATbqiZ4C7IIb2BxEIr+O2DlzW9IUru5jl37Xbhwa7j 7kLp2oKscR4S5ZOsK8b7UnL9DQWO7zGZ5be7XtMWVh9UJxknCelt3um/0DbkX+wr8/Yp BmhkhLBEsTsziluDDYzrCsbpKOjEWTG0DwgnzDMtnH1bJebqm57qf84ImGkDBAwZ7IBU YxpNIXm1dK53aEKLSUb/E+kDc1mkX6jJwAcrzkKD+DYskXtJEjV8f9ttGmgIK0iJfOnW cHsQ== X-Gm-Message-State: ALoCoQmDw0JFMQ+VCUsLlB34HTj+rwnaq6BQ1hVeek31tBMkbm5pN5cgzCddA2djpnenn9BZCdUU X-Received: by 10.180.84.194 with SMTP id b2mr43272278wiz.36.1434468773173; Tue, 16 Jun 2015 08:32:53 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id bo5sm2177378wjc.43.2015.06.16.08.32.51 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Jun 2015 08:32:52 -0700 (PDT) From: Thomas Monjalon To: Simon Kagstrom Date: Tue, 16 Jun 2015 17:31:54 +0200 Message-ID: <19936393.CaRDrBdnp3@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: References: <20150602092155.588bbb2e@miho> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, Johan Faltstrom Subject: Re: [dpdk-dev] [PATCH v2] kni: Add set_rx_mode callback to handle multicast groups X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jun 2015 15:32:53 -0000 > > We did some (very basic) tests with IGMP, which involves adding multicast > > addresses to ETH interfaces. This is done via the ip tool, an example can be found > > on e.g., > > > > http://superuser.com/questions/324824/linux-built-in-or-open-source-program- > > to-join-multicast-group > > > > and this will fail on KNI interfaces because of an unimplemented ioctl > > SIOCADDMULTI. The patch simply adds an empty callback for set_rx_mode > > (typically used for setting up hardware) so that the ioctl succeeds. > > This is the same thing as the Linux tap interface does. > > > > Signed-off-by: Simon Kagstrom > > Signed-off-by: Johan Faltstrom > Acked-by: Helin Zhang Applied, thanks